From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Gopi Krishna Menon <krishnagopi487@gmail.com>,
rafael@kernel.org, daniel.lezcano@kernel.org,
rui.zhang@intel.com, lukasz.luba@arm.com
Cc: daniel.baluta@nxp.com, simona.toaca@nxp.com, d-gole@ti.com,
m-chawdhry@ti.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] thermal: fix error condition for reading st,thermal-flags
Date: Fri, 27 Mar 2026 11:27:47 +0100 [thread overview]
Message-ID: <3f7c9daa-ebf6-4871-8496-0e080afc3322@oss.qualcomm.com> (raw)
In-Reply-To: <20260327090526.59330-1-krishnagopi487@gmail.com>
On 3/27/26 10:05, Gopi Krishna Menon wrote:
> of_property_read_u32 returns 0 on success. The current check returns
> -EINVAL if the property is read successfully.
>
> Fix the check by removing ! from of_property_read_u32
>
> Fixes: b9c7aff481f1 ("drivers/thermal/spear_thermal.c: add Device Tree probing capability")
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> Changes since v1:
> - Add Fixes and Reviewed-by tags
Applied, thanks
prev parent reply other threads:[~2026-03-27 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 9:05 [PATCH v2] thermal: fix error condition for reading st,thermal-flags Gopi Krishna Menon
2026-03-27 10:27 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f7c9daa-ebf6-4871-8496-0e080afc3322@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=d-gole@ti.com \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@kernel.org \
--cc=krishnagopi487@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=m-chawdhry@ti.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=simona.toaca@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox