From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Walleij <linusw@kernel.org>, "Rob Herring (Arm)" <robh@kernel.org>
Cc: Khushal Chitturi <khushalchitturi@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] dt-bindings: power: reset: cortina,gemini-power-controller: convert to DT schema
Date: Sat, 28 Mar 2026 18:31:24 +0100 [thread overview]
Message-ID: <3fa4fad0-d918-4de0-ad80-dad2141d2617@kernel.org> (raw)
In-Reply-To: <CAD++jL=_rCmW=eSV0kvck50sC2xaQnGQoEOy=DNcwkFvvWYUUw@mail.gmail.com>
On 28/03/2026 17:12, Linus Walleij wrote:
> On Sat, Mar 28, 2026 at 3:26 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/reset/cortina,gemini-power-controller.example.dtb: power-controller@4b000000 (cortina,gemini-power-controller): '#power-domain-cells' is a required property
>> from schema $id: http://devicetree.org/schemas/power/power-domain.yaml
>
> Weird, this power controller does not handle power domains whatsoever,
> it handles the mains power. So it should not have any power domain
> cells.
>
> Is this the result of some regexp gone stray?
The name "power controller" is used for power domain controller, so
that's why this name must not be used for other use cases. Usual
replacement is power-management, reboot, restart or poweroff, depending
on what is the purpose of this device.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-28 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 12:47 [PATCH] dt-bindings: power: reset: cortina,gemini-power-controller: convert to DT schema Khushal Chitturi
2026-03-28 14:26 ` Rob Herring (Arm)
2026-03-28 16:12 ` Linus Walleij
2026-03-28 17:31 ` Krzysztof Kozlowski [this message]
2026-03-28 21:28 ` Linus Walleij
2026-03-29 2:09 ` Sebastian Reichel
2026-03-29 18:57 ` Linus Walleij
2026-03-30 6:36 ` Krzysztof Kozlowski
2026-03-28 16:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa4fad0-d918-4de0-ad80-dad2141d2617@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khushalchitturi@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox