From: Artem Bityutskiy <dedekind1@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Linux PM Mailing List <linux-pm@vger.kernel.org>
Subject: Re: [PATCH resend] platform/x86: intel-uncore-freq: add Emerald Rapids support
Date: Thu, 24 Nov 2022 09:04:27 +0200 [thread overview]
Message-ID: <3fc564b6ad31ec8026102dda1a8bd4fbb27161c1.camel@gmail.com> (raw)
In-Reply-To: <01c732b1-7211-8298-61da-0a6892988743@redhat.com>
Hi Hans,
On Wed, 2022-11-23 at 15:37 +0100, Hans de Goede wrote:
> Ugh, no, *NO*! I really expect Intel to do better here!
...
> patch I cannot just go and cherry-pick random patches merged through other trees
> because that may cause conflicts and will cause the merge to look really
> funky.
I did not suggest or imply to cherry-pick.
Back when I was a kernel subsystem maintainer, I did merge Linus' master
sometimes, when there was a good reason. And this is what I implied by asking if
you'd consider updating: the referenced patch is in Linus' tree.
Also, just to be clear. I did accept the criticism in your first reply. This e-
mail seems to partially repeat the criticism, so let me do better job explicitly
addressing it.
1. I apologize for sending this patch against a wrong tree. It was my mistake.
This caused confusion. Sorry for this, and I do mean it. I do realize this
caused troubles and you wasted your time because of this.
2. I apologize for the commit message with more than 75 characters per line. I
acknowledge that I should have followed checkpatch.pl suggestion. Personally, I
do not think it is a big deal, but I do understand that it is not that difficult
to just follow checkpatch.pl suggestions.
I did not participate in kernel community much for the last 7 or so years, and
some of my knowledge/skills are rust/out-of-date. I acknowledge that too. But
basics like "won't cherry pick random patches" I do understand.
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Thank you, this is appreciated.
Artem.
prev parent reply other threads:[~2022-11-24 7:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 7:00 [PATCH resend] platform/x86: intel-uncore-freq: add Emerald Rapids support Artem Bityutskiy
2022-11-22 15:30 ` Hans de Goede
2022-11-23 8:45 ` Artem Bityutskiy
2022-11-23 14:37 ` Hans de Goede
2022-11-23 14:59 ` Rafael J. Wysocki
2022-11-23 15:22 ` Rafael J. Wysocki
2022-11-23 15:54 ` Hans de Goede
2022-11-23 15:57 ` Rafael J. Wysocki
2022-11-23 17:25 ` srinivas pandruvada
2022-11-23 20:59 ` Hans de Goede
2022-11-24 7:04 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fc564b6ad31ec8026102dda1a8bd4fbb27161c1.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-pm@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).