From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [Update][PATCH 3/3] input: i8042: Avoid resetting controller on system suspend/resume Date: Mon, 12 Oct 2015 22:41:41 +0200 Message-ID: <4014904.SIMokX955d@vostro.rjw.lan> References: <10641052.oOBhM6BU9G@vostro.rjw.lan> <5474174.JsPHbLRjZ7@vostro.rjw.lan> <20151012201144.GB4010@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20151012201144.GB4010@dtor-ws> Sender: linux-pci-owner@vger.kernel.org To: Dmitry Torokhov Cc: Linux PM list , Linux Kernel Mailing List , ACPI Devel Maling List , Alan Stern , Daniel Vetter , Bjorn Helgaas , Linux PCI List-Id: linux-pm@vger.kernel.org On Monday, October 12, 2015 01:11:44 PM Dmitry Torokhov wrote: > On Mon, Oct 12, 2015 at 10:17:05PM +0200, Rafael J. Wysocki wrote: > > On Wednesday, October 07, 2015 03:03:57 AM Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > If the upcoming system suspend is not going to be handled by the > > > platform firmware, like in the suspend-to-idle case, it is not > > > necessary to reset the controller in i8042_pm_suspend(), so avoid > > > doing that. > > > > > > Moreover, if the system resume currently in progress has not been > > > started by the platform firmware, like in the suspend-to-idle case, > > > i8042_controller_resume() need not be called by i8042_pm_resume(), > > > so avoid doing that too in that case. > > > > > > Additionally, try to catch the event that woke up the system by > > > calling the interrupt handler early during system resume if it has > > > not been started by the platform firmware. > > > > > > Signed-off-by: Rafael J. Wysocki > > > > If there are no more comments here, I'll tentatively queue it up for v4.4 > > along with the [1-2/3] from this series. > > > > Please let me know if there are any problems with that. > > No problems from my POV. > > Acked-by: Dmitry Torokhov Thanks!