From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF0AC04AB6 for ; Fri, 31 May 2019 09:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E010C266D4 for ; Fri, 31 May 2019 09:29:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbfEaJ3T (ORCPT ); Fri, 31 May 2019 05:29:19 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:52236 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726403AbfEaJ3T (ORCPT ); Fri, 31 May 2019 05:29:19 -0400 Received: from 79.184.255.225.ipv4.supernova.orange.pl (79.184.255.225) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.213) id b1c8d75ad1f69e80; Fri, 31 May 2019 11:29:17 +0200 From: "Rafael J. Wysocki" To: Geert Uytterhoeven Cc: Pavel Machek , Len Brown , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / clk: Remove error message on out-of-memory condition Date: Fri, 31 May 2019 11:29:16 +0200 Message-ID: <4033832.t2mNCoI3x2@kreacher> In-Reply-To: <20190527122751.6430-1-geert+renesas@glider.be> References: <20190527122751.6430-1-geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Monday, May 27, 2019 2:27:51 PM CEST Geert Uytterhoeven wrote: > There is no need to print an error message if kstrdup() fails, as the > memory allocation core already takes care of that. > > Note that commit 59d84ca8c46a93ad ("PM / OPP / clk: Remove unnecessary > OOM message") already removed similar error messages, but this one was > forgotten. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/base/power/clock_ops.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c > index 59d19dd649289287..1cf86fcaeff8faac 100644 > --- a/drivers/base/power/clock_ops.c > +++ b/drivers/base/power/clock_ops.c > @@ -92,8 +92,6 @@ static int __pm_clk_add(struct device *dev, const char *con_id, > if (con_id) { > ce->con_id = kstrdup(con_id, GFP_KERNEL); > if (!ce->con_id) { > - dev_err(dev, > - "Not enough memory for clock connection ID.\n"); > kfree(ce); > return -ENOMEM; > } > Applied, thanks!