From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Waldemar Rymarkiewicz <waldemarx.rymarkiewicz@intel.com>,
WaldemarRymarkiewiczwaldemar.rymarkiewicz@gmail.com,
linux-pm@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v2 1/1] PM / OPP: Fix get sharing cpus when hotplug is used
Date: Wed, 26 Jul 2017 02:17:15 +0200 [thread overview]
Message-ID: <4051208.gOcJRl3Z1H@aspire.rjw.lan> (raw)
In-Reply-To: <CAHKzcEONE7CUyqdQC5X45S9oWLa9iEbyVd4gpgiYBuU4vQeKUA@mail.gmail.com>
On Tuesday, July 25, 2017 10:09:42 AM Waldemar Rymarkiewicz wrote:
> On 24 July 2017 at 23:04, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Monday, July 24, 2017 02:17:13 PM Viresh Kumar wrote:
> >> On 21-07-17, 14:13, Waldemar Rymarkiewicz wrote:
> >> > We fail dev_pm_opp_of_get_sharing_cpus() when possible cpu device does not
> >> > exist. This can happen on platforms where not all possible CPUs are
> >> > available at start up ie. hotplugged out. Cpu device is not registered in
> >> > the system so we are not able to check struct device to set the sharing
> >> > CPUs bitmask properly.
> >> >
> >> > Example (real use case):
> >> > 2 physical MIPS cores, 4 VPE, cpu0/2 run Linux and cpu1/3 are not available
> >> > for Linux at boot up. cpufreq-dt driver + opp v2 fail to register opp_table
> >> > due to the fact there is no struct device for cpu1 (remains offline at
> >> > bootup).
> >> >
> >> > To solve the bug, stop using device struct to check device_node. Instead
> >> > get cpu device_node directly from device tree with of_get_cpu_node().
> >> >
> >> > Signed-off-by: Waldemar Rymarkiewicz <waldemarx.rymarkiewicz@intel.com>
> >> > ---
> >> > drivers/base/power/opp/of.c | 28 +++++++++++++++++-----------
> >> > 1 file changed, 17 insertions(+), 11 deletions(-)
> >>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > I've lost track of this, care to resend?
>
> I've resent v3.
Well, I'm not seeing it in any of my mailboxes.
Have you CCed it to the mailing lists?
prev parent reply other threads:[~2017-07-26 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170721121403.31202-1-waldemarx.rymarkiewicz@intel.com>
2017-07-24 8:47 ` [PATCH v2 1/1] PM / OPP: Fix get sharing cpus when hotplug is used Viresh Kumar
2017-07-24 21:04 ` Rafael J. Wysocki
2017-07-25 8:09 ` Waldemar Rymarkiewicz
2017-07-26 0:17 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4051208.gOcJRl3Z1H@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=WaldemarRymarkiewiczwaldemar.rymarkiewicz@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@codeaurora.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
--cc=waldemarx.rymarkiewicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox