From: Mikko Perttunen <cyndis@kapsi.fi>
To: Jon Hunter <jonathanh@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
rjw@rjwysocki.net, viresh.kumar@linaro.org,
thierry.reding@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster
Date: Mon, 3 Apr 2017 18:19:49 +0300 [thread overview]
Message-ID: <40534e51-db02-6eb2-2426-b34a5ea0f61d@kapsi.fi> (raw)
In-Reply-To: <87a034c6-ed81-4656-9593-b5708e65edb1@nvidia.com>
On 04/03/2017 05:24 PM, Jon Hunter wrote:
>
> On 03/04/17 13:42, Mikko Perttunen wrote:
>> The Tegra186 CCPLEX_CLUSTER area contains memory-mapped
>> registers that initiate CPU frequency/voltage transitions.
>>
>> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>> ---
>> .../arm/tegra/nvidia,tegra186-ccplex-cluster.txt | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt
>> new file mode 100644
>> index 000000000000..50cd615219e9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt
>> @@ -0,0 +1,22 @@
>> +NVIDIA Tegra CCPLEX_CLUSTER area
>> +
>> +Required properties:
>> +- compatible: Should contain one of the following:
>> + - "nvidia,tegra186-ccplex-cluster": for Tegra186
>
> Nit pick ... any reason why we append 'cluster' here? The TRM just says
> the "CPU Complex" consists of two CPU clusters. So
> "nvidia,tegra186-cpu-complex" or "nvidia,tegra186-ccplex" seems fine.
>
> BTW, I do see references in the TRM to CCPLEX_CLUSTER0/1, but never
> CCPLEX_CLUSTER in reference to both. I think it is just CCPLEX AFAICT.
The reason was that the MMIO aperture is called "CCPLEX_CLUSTER" in the
address map. But I agree it's not a very descriptive name.
>
> Cheers
> Jon
>
next prev parent reply other threads:[~2017-04-03 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 12:42 [PATCH 1/3] cpufreq: Add Tegra186 cpufreq driver Mikko Perttunen
2017-04-03 12:42 ` [PATCH 3/3] arm64: tegra: Add CCPLEX_CLUSTER area in Tegra186 Mikko Perttunen
[not found] ` <1491223345-24386-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-04-03 12:42 ` [PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster Mikko Perttunen
2017-04-03 14:06 ` Thierry Reding
[not found] ` <20170403140617.GA22966-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2017-04-03 15:18 ` Mikko Perttunen
2017-04-03 14:24 ` Jon Hunter
2017-04-03 15:19 ` Mikko Perttunen [this message]
2017-04-03 14:47 ` [PATCH 1/3] cpufreq: Add Tegra186 cpufreq driver Thierry Reding
2017-04-03 15:38 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40534e51-db02-6eb2-2426-b34a5ea0f61d@kapsi.fi \
--to=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).