Re: [PATCH] cpuidle: fix warning when compile

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Tuesday 23 of October 2012 22:45:28 Youquan Song wrote:
> Fix the warning complain when compile the kernel.
> 
> drivers/cpuidle/governors/menu.c: In function 'get_typical_interval':
> drivers/cpuidle/governors/menu.c:268:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> drivers/cpuidle/governors/menu.c:277:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> 
> Signed-off-by: Youquan Song <youquan.song@intel.com>
> ---
>  drivers/cpuidle/governors/menu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
> index 26d5667..2efee27 100644
> --- a/drivers/cpuidle/governors/menu.c
> +++ b/drivers/cpuidle/governors/menu.c
> @@ -248,7 +248,7 @@ static enum hrtimer_restart menu_hrtimer_notify(struct hrtimer *hrtimer)
>  static u32 get_typical_interval(struct menu_device *data)
>  {
>  	int i = 0, divisor = 0;
> -	int64_t max = 0, avg = 0, stddev = 0;
> +	uint64_t max = 0, avg = 0, stddev = 0;
>  	int64_t thresh = LLONG_MAX; /* Discard outliers above this value. */

Shouldn't this one be uint64_t too?

>  	unsigned int ret = 0;

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.