From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C497305E3F for ; Tue, 16 Sep 2025 10:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758018582; cv=none; b=IBJlw2fkfr6l/zzYSdk3xmRL7tUHgncEfJqvCYlLWyEdAhzbXlrGG7zwr0QD66ldq8cu1n4o2KW5eQWtI9r4k3GiDqAutB9IPjKlxCjIBNr8YfXAYgi5SzAhQq1/XOKW9sPrR3kW9v398dgFfsRXYNZsiA+2NyOrHtNX5ka6WQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758018582; c=relaxed/simple; bh=ygtB+EvH4ZQAJq4PlbVuhMBsLl2taMUDDFSXeqxgpe4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cf0RjAmQ4g+irSja5ffAkRXSmd7uHlw50jaNsyOztlOoxqCMCTlVvUzgbjeAqClwsiSW8ET3Yn4KqvF3BMmwBCWAqlIX/r+XsFXQwj+aQIE4OA03BG95T8fmvU85k4e9wHgfCH2phCwK234QElyUibLmSgtLzBfJ0q8vGWBauTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YSUqnefp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YSUqnefp" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58GAKFKo001544 for ; Tue, 16 Sep 2025 10:29:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GU+SrKKCCt7QHKhnQ0Qwpe7d/gooxwsnRu7znj5bEtU=; b=YSUqnefpDpieJ5OB jCzjlZvaJUP4u6G1NzieAHCckj+fW/7U3s+flo1Mov0rLDcp74u44eFt263Ku2fP W0sNzrhQoGmTh3rWz1yaKC8A4FvmJdFtzG3u9CHrmRcI4FsN8nMejZgHI0GjTVh+ UJQ6Mh+YiND5CVkJTc3hdvHPEnNgVZNpvII5ksQD4zxz35PZNIBAjhh8cpR/DL+L gUzNXNaPm2bT7Ri3CPZ+dudzZETWOnMg9LX+9W8pZCL1vvEyMtsxACjyBrNdL5MI EURQD72pkMQcHZh1BS+bli8Xoos7zCUPbvRqQRSAB6ZcsFygS8PXBV/ZmiKU6tyJ GVUzRg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 495eqpygmb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 16 Sep 2025 10:29:39 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4b5f92a6936so14432511cf.3 for ; Tue, 16 Sep 2025 03:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758018578; x=1758623378; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GU+SrKKCCt7QHKhnQ0Qwpe7d/gooxwsnRu7znj5bEtU=; b=L/NqIvkt5EbG0Mws6kpVDxwzF0fxMk88Ppdkw2zfU/1NbwKDsdTy7nfTxZ01004rJc GLLTADW9mcgJ+4zONeVkitwnNNWt0HWTmxHlXGF6wCSX2ddL/q6tGi1ZjNPfaFoksZb3 bUnXH7X4EO6Tibm6rYsvwpNGEp9VBOQg861ajdzdVxNmKGkDhvcfe8LG/9xzT+eRfaGo Gpj2iQPGdmjxENy/nT+M33VPyejSd6bNvTDBOt4p70NY8U+w32eJx0E3I7/eJREpyG3Z Emp4wBnRyVDOxygWHPBhTD9KPDv/oniqaot0J8292c3jgKbeKpUCCSJiXhgCfwaypQcn qLSg== X-Forwarded-Encrypted: i=1; AJvYcCWnAfQgDg/yn5MhEIqPzyyG46KkTOxmb3p95K/Fh5u12NzCQtDkdp7Pvb17iPfMf+MGX5HB04VhKQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yy4yBJlr9c9e7rVMULXgxPjX5Aurs48A3eP3yGgnqChhrNbMso1 u5gC19ETxuE+Tm8zfanj3a+hTxjM0JCZiWI9pLalP0NKw7v8UWR1uA9EwvvdvE5lrkI+KsGI89e ah6PqphcSb3eAE1RQj2q21x667vjkYv8Y0+E9HBsklifzbQCaQfCur5iSi43C0w== X-Gm-Gg: ASbGncsuDVSjUmlsgvqWbpeU7eETJ6lvPOdQZ9I1aVCjZd7pkgNa1UijE/jQrQYFcc7 te5DTri715wBBnJnosTo4Z2ltz04nTBVloxc6KAvj4kI3Xfuv6+PFmQxAgj5JPEpJcIiidXquj+ JJs15B4vrSD40UJl8/iK10zKohxtr2rTo0nPqlQu/TXIG1qfYXFCq3sQrp4o5Ok2EdTmDDCSAYa rEjpiR1RHNPnkxL2AcG8ZzpMza1KED9ozqRitEji6ussOGTIjvBT5NFaeO3qEC52zhnsEco5DEV 7x6tlp3Mc4Sf2geJN0fsvFHMUDarkCz1rY9aK28hTxV+v6TLuwRV7/RQiJvkE+W2pi8BlkhjUs1 9tEKkUmsFpTxiMpDFQhpZxQ== X-Received: by 2002:a05:622a:22a6:b0:4b7:94af:2998 with SMTP id d75a77b69052e-4b794af2d57mr70830071cf.6.1758018578481; Tue, 16 Sep 2025 03:29:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFc/Zty3StI1tWgqDi2/Q43n+FRGSKUym0DsgirXM6iKjzPgKG47iW4ZaAI3syn3pqhogsDdQ== X-Received: by 2002:a05:622a:22a6:b0:4b7:94af:2998 with SMTP id d75a77b69052e-4b794af2d57mr70829761cf.6.1758018577808; Tue, 16 Sep 2025 03:29:37 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62f3919e168sm4139507a12.34.2025.09.16.03.29.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Sep 2025 03:29:37 -0700 (PDT) Message-ID: <40ff4fbb-1495-4374-b8ac-1bd4b2bb7463@oss.qualcomm.com> Date: Tue, 16 Sep 2025 12:29:35 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/8] arm64: dts: qcom: x1e80100-crd: Add charge limit nvmem To: Dmitry Baryshkov , fenglin.wu@oss.qualcomm.com Cc: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Bryan O'Donoghue , Subbaraman Narayanamurthy , David Collins , =?UTF-8?Q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Neil Armstrong References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> <20250915-qcom_battmgr_update-v4-8-6f6464a41afe@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 1snwBakyHBmgbS4CT-hjs2NzVLrcYhQi X-Proofpoint-ORIG-GUID: 1snwBakyHBmgbS4CT-hjs2NzVLrcYhQi X-Authority-Analysis: v=2.4 cv=XJIwSRhE c=1 sm=1 tr=0 ts=68c93c13 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=x0UozUpXlkEbfjVD_VEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDE4NiBTYWx0ZWRfX6b5OXm9IXxSB VG/aAiAkuf3WgwKPGrPEZAH8F2O7qQQixfWDQ5acnHew6OMRFL6veZ31y9rSIcpDOVMAKAV1mM7 qWdFtfNI1UZOX/M40U3D3HoWbEWDADij3bNg9LH3WUEjOL5pSg3KDOaahFEeq/h4s0rTFGOmdm1 1d5Rekiauh9vMB8eUlFhTyZp8xFFlPK0TBQAc6Dyo8oi8EFibJaiupvhId90DJuFJtlPnHUjUC2 3C516JPaCoS8fm+pWw6gV5V2YzT/EDKDZEDWoSByxQ517AbWhpT0taji3SSSnDi7DSerx1wS8qG Vci7CsLcwxUlUtba0DE53JpxouMxcq5+GonwqNBMri67b4HSBM9AJljD7R70JuLwBuiBTdbsAop qNcDz3NN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-16_02,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509130186 On 9/15/25 12:20 PM, Dmitry Baryshkov wrote: > On Mon, Sep 15, 2025 at 04:50:00PM +0800, Fenglin Wu via B4 Relay wrote: >> From: Fenglin Wu >> >> Add nvmem cells for getting charge control thresholds if they have >> been set previously. >> >> Tested-by: Neil Armstrong # on Thinkpad T14S OLED >> Signed-off-by: Fenglin Wu >> --- >> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 3 +++ >> arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 20 ++++++++++++++++++++ >> 2 files changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >> index c9f0d505267081af66b0973fe6c1e33832a2c86b..fee65391653ae9c2ee23f9f3954d9ed018c9aecd 100644 >> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi >> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >> @@ -82,6 +82,9 @@ pmic-glink { >> <&tlmm 123 GPIO_ACTIVE_HIGH>, >> <&tlmm 125 GPIO_ACTIVE_HIGH>; >> >> + nvmem-cells = <&charge_limit_en>, <&charge_limit_end>, <&charge_limit_delta>; > > One item per line, please. > >> + nvmem-cell-names = "charge_limit_en", "charge_limit_end", "charge_limit_delta"; > > And here too. With that: Reviewed-by: Konrad Dybcio Konrad