From: Arnd Bergmann <arnd@arndb.de>
To: linaro-kernel@lists.linaro.org
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
Lior Amsalem <alior@marvell.com>,
Rob Herring <rob.herring@linaro.org>,
"pramod.gurav@smartplayin.com" <pramod.gurav@smartplayin.com>,
Tawfik Bayouk <tawfik@marvell.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Nadav Haklai <nadavh@marvell.com>,
Thomas Abraham <thomas.ab@samsung.com>,
Mike Turquette <mike.turquette@linaro.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sachin Kamat <spk.linux@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCHv2 2/4] cpufreq: cpufreq-dt: extend with platform_data
Date: Wed, 10 Sep 2014 14:36:12 +0200 [thread overview]
Message-ID: <4101334.fU3EzedaAi@wuerfel> (raw)
In-Reply-To: <CAKohpo=EPrwbu7RhyXAXeq2U9uV2BeLZHrMKTg3oAF1oZb0QmA@mail.gmail.com>
On Wednesday 10 September 2014 18:02:59 Viresh Kumar wrote:
> > I'm using platform_device_register_data(), which does a kmemdup() of
> > the custom data being passed before assigning the struct
> > device->platform_data field.
>
> Atleast in your case it isn't required to copy anymore but this driver can be
> used by others which may not guarantee that..
>
> > But if you like, I can add one more memory copy
>
> Its not what I like, as wasting memory isn't sensible at all.. But about what's
> the right thing to do to make this code un-breakable..
>
> @Arnd: Any inputs?
platform_device_register_data() is the right way to register a platform
device if one needs to do that, and it will always copy the data,
so that should be used, and the driver should rely on the data not
getting freed under it.
Statically defining platform_device instances is generally a bad idea,
and we should not do that, but if someone does it is up to them to
make sure the platform_data is not marked as __init.
Arnd
next prev parent reply other threads:[~2014-09-10 12:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 4:29 [PATCH] cpufreq: dt: Support platforms with separate clock lines for each CPU Viresh Kumar
2014-09-10 6:29 ` Thomas Petazzoni
2014-09-10 6:42 ` Viresh Kumar
2014-09-10 9:41 ` [PATCH 0/4] cpufreq-dt, platform_data based proposal Thomas Petazzoni
2014-09-10 9:41 ` [PATCH 1/4] cpufreq: allow driver-specific flags Thomas Petazzoni
2014-09-10 10:49 ` Viresh Kumar
2014-09-27 22:44 ` Mike Turquette
2014-09-29 8:54 ` Viresh Kumar
[not found] ` <20141005004102.4379.42626@quantum>
2014-10-06 3:56 ` Viresh Kumar
[not found] ` <20141006183624.4379.26437@quantum>
2014-10-06 18:55 ` Thomas Petazzoni
2014-10-06 21:44 ` Mike Turquette
2014-10-07 3:27 ` Viresh Kumar
2014-10-07 3:25 ` Viresh Kumar
2014-10-08 7:48 ` [PATCH 0/2] allow cpufreq drivers to export flags Mike Turquette
2014-10-08 7:48 ` [PATCH 1/2] cpufreq: add driver flag for sleepable transitions Mike Turquette
2014-10-08 7:48 ` [PATCH 2/2] cpufreq: new function to query driver for flags Mike Turquette
2014-10-08 7:54 ` [PATCH 0/2] allow cpufreq drivers to export flags Viresh Kumar
2014-10-08 8:11 ` Thomas Petazzoni
2014-10-08 8:19 ` Viresh Kumar
2014-10-09 0:01 ` Mike Turquette
2014-10-09 3:37 ` Viresh Kumar
2014-09-10 9:41 ` [PATCH 2/4] cpufreq: cpufreq-dt: extend with platform_data Thomas Petazzoni
2014-09-10 9:41 ` [PATCH 3/4] ARM: mvebu: use the cpufreq-dt platform_data for independent clocks Thomas Petazzoni
2014-09-10 9:41 ` [PATCH 4/4] cpufreq: cpufreq-dt: remove warning about regulators Thomas Petazzoni
2014-09-10 10:30 ` Viresh Kumar
2014-09-10 9:53 ` [PATCH 0/4] cpufreq-dt, platform_data based proposal Arnd Bergmann
2014-09-10 10:10 ` Thomas Petazzoni
2014-09-10 10:19 ` Arnd Bergmann
2014-09-10 10:30 ` Thomas Petazzoni
2014-09-10 18:15 ` Stephen Boyd
2014-09-10 10:38 ` Viresh Kumar
2014-09-10 11:37 ` Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 " Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 1/4] cpufreq: allow driver-specific data Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 2/4] cpufreq: cpufreq-dt: extend with platform_data Thomas Petazzoni
2014-09-10 12:22 ` Viresh Kumar
2014-09-10 12:28 ` Thomas Petazzoni
2014-09-10 12:32 ` Viresh Kumar
2014-09-10 12:36 ` Arnd Bergmann [this message]
2014-09-10 12:08 ` [PATCHv2 3/4] ARM: mvebu: use the cpufreq-dt platform_data for independent clocks Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 4/4] cpufreq: cpufreq-dt: adjust message related to regulators Thomas Petazzoni
2014-09-10 12:23 ` Viresh Kumar
2014-09-10 12:38 ` [PATCHv2 0/4] cpufreq-dt, platform_data based proposal Viresh Kumar
2014-09-23 9:26 ` Thomas Petazzoni
2014-10-06 7:19 ` Thomas Petazzoni
2014-10-06 22:53 ` Rafael J. Wysocki
2014-10-07 3:30 ` Viresh Kumar
2014-10-07 23:59 ` Rafael J. Wysocki
2014-10-08 5:51 ` Viresh Kumar
2014-10-12 20:25 ` Rafael J. Wysocki
2014-10-19 9:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4101334.fU3EzedaAi@wuerfel \
--to=arnd@arndb.de \
--cc=alior@marvell.com \
--cc=arnd.bergmann@linaro.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.turquette@linaro.org \
--cc=nadavh@marvell.com \
--cc=pramod.gurav@smartplayin.com \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=spk.linux@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.ab@samsung.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).