From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5657D19FA93; Wed, 30 Jul 2025 13:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753883184; cv=pass; b=M0FSOdYJQZlHQrME5HIoyWhqR0IgiRkDwk09FfrONk65Q2P7jDVdzM8AQk+eOZhGOqmjTK+Ps53w6qBKQHTZJ1gcGjmskUexwy6v9yVyiHFI1wCWK+VekSPu0j922lgPfbAzJljUI5EPVT5hsmlRhnwmb1cXsxVyRyH3+V+rsfU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753883184; c=relaxed/simple; bh=bjaYcvz3v5WfyEQxm4uFwostHIKvCC25+5SRLNwNrs8=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=R0Tyxfd6FPDO4FO0M6/yns392HptQ3tgdGVx5Ibh4weaSYWT8KLO6P2MAwPB7IybZqsK3emojNjznLfUy+4XanrkWCalJBwIbYT2L31t7NZv8xQ70YMyevBydacqpouZVbdAQImudWX0MmKvhnyxM6CXzbBEqQheGcYentfowcI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=LD3uIyuJ; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="LD3uIyuJ" ARC-Seal: i=1; a=rsa-sha256; t=1753883163; cv=none; d=zohomail.com; s=zohoarc; b=FJknu8xzr9PfmL2ZWVbr5ZsEGbA8PLtBMN/4dY2WqaKyHm+lUwff5k6dwPYbxD5JT2+TtnZhYSE97p6ew8XsIHwiHPqGN4A6zD3CS1JsDCUiy/M/dd9lQPfPBl5d2uCDxzNEe2fGE0HhwFXnMLCHIM+XBC1SgSUh9eknLxmh3LY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753883163; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=bjaYcvz3v5WfyEQxm4uFwostHIKvCC25+5SRLNwNrs8=; b=TIDw9k1Brmbkl9jQqBQxMM11Vsj9Ze1o0kdvv/3/bNgpACbAgd2wTCbkHe1m2S4pcE/sB3DIeLVvJOZ8d79Z2WbI6WcGZf7D/0g8VxvFTavAETqt4WqCL+ctABcrAf8WHWO6IJnJdxseaNxSEFhInX51g59NvU8LjYgqks/nQWI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753883163; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=bjaYcvz3v5WfyEQxm4uFwostHIKvCC25+5SRLNwNrs8=; b=LD3uIyuJi9ntvAWrT3TnWNCE+pSsn80skqbi4WRyZmr8EqpOPZq9uYx8Okv4wYuE e5uw9vWhGII+fCkInRXpViDQC/3MXkUrSxaH6KJvcXuy6pyMRqin6oPvyFUlpboGdOT brOpyg0l7SbfDC3Tl9LiIVn20pNXmd6sUb2oFskA= Received: by mx.zohomail.com with SMTPS id 1753883157044881.6279461529779; Wed, 30 Jul 2025 06:45:57 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: [PATCH] rust: clk: use the type-state pattern From: Daniel Almeida In-Reply-To: Date: Wed, 30 Jul 2025 10:45:39 -0300 Cc: Daniel Sedlak , Benno Lossin , Michael Turquette , Stephen Boyd , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Viresh Kumar , Alexandre Courbot , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <41B46C07-5408-41ED-91F9-CB3979944DCB@collabora.com> References: <20250729-clk-type-state-v1-1-896b53816f7b@collabora.com> <07575756-58EA-4245-B837-AEC4DDCD0DB5@collabora.com> <20cc8581-0af2-47b3-9fdd-584ff0ef36ab@sedlak.dev> To: Alice Ryhl X-Mailer: Apple Mail (2.3826.600.51.1.1) X-ZohoMailClient: External Hi Alice, > It seems a bit much to have macros for everything. I understand your point of view, but at this point the =E2=80=9Cmod = private=E2=80=9D boilerplate is growing by the day. It would at least make reviews slightly easier, because reviewers don't = have to ask themselves whether the submitter implemented the pattern correctly. IMHO, of course. =E2=80=94 Daniel=