From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@sisk.pl
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Eric Miao <eric.y.miao@gmail.com>
Subject: [PATCH 25/31] cpufreq: pxa: Covert to light weight ->target() routine
Date: Mon, 12 Aug 2013 23:19:01 +0530 [thread overview]
Message-ID: <41ec8b00a1b81ef8c8aadf0852d24da7a22a6d61.1376329128.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1376329128.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1376329128.git.viresh.kumar@linaro.org>
This patch converts existing .target_old() to newly defined light weight
.target() routine for this driver.
CPUFreq core will call cpufreq_frequency_table_target() before calling this
routine and will pass index to it.
Cc: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/pxa2xx-cpufreq.c | 13 ++-----------
drivers/cpufreq/pxa3xx-cpufreq.c | 17 +++--------------
2 files changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
index aff9800..fa5026b 100644
--- a/drivers/cpufreq/pxa2xx-cpufreq.c
+++ b/drivers/cpufreq/pxa2xx-cpufreq.c
@@ -267,14 +267,11 @@ static unsigned int pxa_cpufreq_get(unsigned int cpu)
return get_clk_frequency_khz(0);
}
-static int pxa_set_target(struct cpufreq_policy *policy,
- unsigned int target_freq,
- unsigned int relation)
+static int pxa_set_target(struct cpufreq_policy *policy, unsigned int idx)
{
struct cpufreq_frequency_table *pxa_freqs_table;
pxa_freqs_t *pxa_freq_settings;
struct cpufreq_freqs freqs;
- unsigned int idx;
unsigned long flags;
unsigned int new_freq_cpu, new_freq_mem;
unsigned int unused, preset_mdrefr, postset_mdrefr, cclkcfg;
@@ -283,12 +280,6 @@ static int pxa_set_target(struct cpufreq_policy *policy,
/* Get the current policy */
find_freq_tables(&pxa_freqs_table, &pxa_freq_settings);
- /* Lookup the next frequency */
- if (cpufreq_frequency_table_target(policy, pxa_freqs_table,
- target_freq, relation, &idx)) {
- return -EINVAL;
- }
-
new_freq_cpu = pxa_freq_settings[idx].khz;
new_freq_mem = pxa_freq_settings[idx].membus;
freqs.old = policy->cur;
@@ -450,7 +441,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
static struct cpufreq_driver pxa_cpufreq_driver = {
.verify = cpufreq_generic_frequency_table_verify,
- .target_old = pxa_set_target,
+ .target = pxa_set_target,
.init = pxa_cpufreq_init,
.exit = cpufreq_generic_exit,
.get = pxa_cpufreq_get,
diff --git a/drivers/cpufreq/pxa3xx-cpufreq.c b/drivers/cpufreq/pxa3xx-cpufreq.c
index 6cedfbf..58a904f 100644
--- a/drivers/cpufreq/pxa3xx-cpufreq.c
+++ b/drivers/cpufreq/pxa3xx-cpufreq.c
@@ -155,24 +155,16 @@ static unsigned int pxa3xx_cpufreq_get(unsigned int cpu)
return pxa3xx_get_clk_frequency_khz(0);
}
-static int pxa3xx_cpufreq_set(struct cpufreq_policy *policy,
- unsigned int target_freq,
- unsigned int relation)
+static int pxa3xx_cpufreq_set(struct cpufreq_policy *policy, unsigned int index)
{
struct pxa3xx_freq_info *next;
struct cpufreq_freqs freqs;
unsigned long flags;
- int idx;
if (policy->cpu != 0)
return -EINVAL;
- /* Lookup the next frequency */
- if (cpufreq_frequency_table_target(policy, pxa3xx_freqs_table,
- target_freq, relation, &idx))
- return -EINVAL;
-
- next = &pxa3xx_freqs[idx];
+ next = &pxa3xx_freqs[index];
freqs.old = policy->cur;
freqs.new = next->cpufreq_mhz * 1000;
@@ -181,9 +173,6 @@ static int pxa3xx_cpufreq_set(struct cpufreq_policy *policy,
freqs.old / 1000, freqs.new / 1000,
(freqs.old == freqs.new) ? " (skipped)" : "");
- if (freqs.old == target_freq)
- return 0;
-
cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);
local_irq_save(flags);
@@ -224,7 +213,7 @@ static int pxa3xx_cpufreq_init(struct cpufreq_policy *policy)
static struct cpufreq_driver pxa3xx_cpufreq_driver = {
.verify = cpufreq_generic_frequency_table_verify,
- .target_old = pxa3xx_cpufreq_set,
+ .target = pxa3xx_cpufreq_set,
.init = pxa3xx_cpufreq_init,
.exit = cpufreq_generic_exit,
.get = pxa3xx_cpufreq_get,
--
1.7.12.rc2.18.g61b472e
next prev parent reply other threads:[~2013-08-12 17:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 17:48 [PATCH 00/31] CPUFreq: Implement light weight ->target(): for 3.13 Viresh Kumar
2013-08-12 17:48 ` [PATCH 01/31] cpufreq: rename ->target() as ->target_old() Viresh Kumar
2013-08-12 17:48 ` [PATCH 02/31] cpufreq: Implement light weight ->target() routine Viresh Kumar
2013-08-12 17:48 ` [PATCH 03/31] cpufreq: acpi: Covert to " Viresh Kumar
2013-08-12 17:48 ` [PATCH 04/31] cpufreq: arm_big_little: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 05/31] cpufreq: blackfin: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 06/31] cpufreq: cpu0: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 07/31] cpufreq: cris: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 08/31] cpufreq: davinci: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 09/31] cpufreq: dbx500: " Viresh Kumar
2013-08-15 19:52 ` Linus Walleij
2013-08-12 17:48 ` [PATCH 10/31] cpufreq: e_powersaver: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 11/31] cpufreq: elanfreq: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 12/31] cpufreq: exynos: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 13/31] cpufreq: ia64: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 14/31] cpufreq: imx6q: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 15/31] cpufreq: kirkwood: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 16/31] cpufreq: longhaul: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 17/31] cpufreq: loongson2: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 18/31] cpufreq: maple: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 19/31] cpufreq: omap: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 20/31] cpufreq: p4: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 21/31] cpufreq: pasemi: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 22/31] cpufreq: pmac32: " Viresh Kumar
2013-08-12 17:48 ` [PATCH 23/31] cpufreq: powernow: " Viresh Kumar
2013-08-12 17:49 ` [PATCH 24/31] cpufreq: ppc: " Viresh Kumar
2013-08-12 17:49 ` Viresh Kumar [this message]
2013-08-12 17:49 ` [PATCH 26/31] cpufreq: s3c64xx: " Viresh Kumar
2013-08-12 17:49 ` [PATCH 27/31] cpufreq: sc520: " Viresh Kumar
2013-08-12 17:49 ` [PATCH 28/31] cpufreq: sparc: " Viresh Kumar
2013-08-12 17:49 ` [PATCH 29/31] cpufreq: SPEAr: " Viresh Kumar
2013-08-12 17:49 ` [PATCH 30/31] cpufreq: speedstep: " Viresh Kumar
2013-08-12 17:49 ` [PATCH 31/31] cpufreq: tegra: " Viresh Kumar
2013-08-12 22:47 ` [PATCH 00/31] CPUFreq: Implement light weight ->target(): for 3.13 Rafael J. Wysocki
2013-08-13 4:49 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ec8b00a1b81ef8c8aadf0852d24da7a22a6d61.1376329128.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=eric.y.miao@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).