From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v1 7/7] power: bq24190_charger: Set bq24190-battery device .type=unknown Date: Wed, 22 Mar 2017 15:41:09 +0100 Message-ID: <41f97886-306e-725f-4b05-dc98a3b57fa1@redhat.com> References: <20170321220921.5834-1-liam@networkimprov.net> <20170321220921.5834-8-liam@networkimprov.net> <7e117a52-bbf0-2a12-e98f-843da227e0c7@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36636 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbdCVOuR (ORCPT ); Wed, 22 Mar 2017 10:50:17 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Liam Breck Cc: Sebastian Reichel , Tony Lindgren , linux-pm@vger.kernel.org Hi, On 22-03-17 14:37, Liam Breck wrote: > On Wed, Mar 22, 2017 at 6:15 AM, Hans de Goede wrote: >> Hi, >> >> On 22-03-17 13:25, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 21-03-17 23:09, Liam Breck wrote: >>>> >>>> From: Liam Breck >>>> >>>> Not for upstream. Temporary workaround to prevent bq24190-battery device >>>> from interfering with a fuel gauge that has >>>> .type=power_supply_type_battery >>>> >>>> I'll move properties from -battery device to -charger in a subsequent >>>> version. >>>> >>>> Cc: Hans de Goede >>> >>> >>> Hmm, I don't like this. I was about to post v2 of my patches (which I will >>> rebase on top of this series) >> >> >> It seems this series does not apply to: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next >> >> It looks like there is another series which sits in between ? > > Yes, see two patches linked in Depends-on lines. Could you add those and rebase? I can confirm that with those 2 patches thrown in things apply cleanly on linux-power-supply/for-next. I see that these 2 patches add a new devicetree binding for describing a battery. That is really cool stuff and long overdue IMHO I'm glad to see someone doing this. But (sorry) in my experience getting new devicetree bindings upstream often takes a while, while people are discussing the best way to solve things. So I'm not quite sure this will go upstream real soon now and I would like to get my patches into -next in time for 4.12 if possible. So for now I'm going to hold of on rebasing and just send v2 as is (based on linux-power-supply/for-next). If Sebastian thinks your patches should go first I will happily do a rebased v3. Regards, Hans