From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBA6C13AD3F; Thu, 5 Jun 2025 15:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749136537; cv=pass; b=PkBrasjIY+HYKgngfqp4BTQFxppuNdxtKK/2iAmH2yg7ZFrP/xq+cmswabegei6kwjZnfIeRFOm8jvWgC07sAXLkVlQ3yWN0rGvuVfdm3b63anZPOCIwgSJgkInPgkW/8ssxRT0bV8BLFCPWdw4UkGhY3iy1IJ83QenSbZs7E0w= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749136537; c=relaxed/simple; bh=GgJMseciY2sRjSScoO4X8MCR1HDf9uZ8s4u0sGGTtAc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PwUQZ+oJIHhUU1j+RS3BZAOQKWCBidqHjrL2A1HLZp5dxLdJwmn62VQQ4lst1AOYOq1ocMlVurlKJ20iAQ8RV0jK7gDSIhkXVAt0RKjloBZvy6MaMjfw2Lxxddyr3A4b6eucbujIPUG0uq+PhQ+HzjEGhzwq+aRwKMsu0WMdhzc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=e51u7eqb; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="e51u7eqb" ARC-Seal: i=1; a=rsa-sha256; t=1749136492; cv=none; d=zohomail.com; s=zohoarc; b=ENI8hMjvEmJfVrQRZSFpDbyKHVOtvfZuTm5qF/vEk1X9P4OigUMMG7qLVI2qosebz8ddrxGGYzEZZiDtjkR/dCK0ZzXU3/xZFoNQI6xUCziEB0er4zPVxDzJaiJQt0t0dnHoGf0FOh/E7kyj9Lb841Ko3RteQbTAgBr7G0EjjoA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749136492; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=/GuYrfRIt3NP/tsfwxH5PFscLlX5erdLhDtZ3+v8kg0=; b=CiS2fKxauqWUQMP1ejrx8adcDEkkl3oZ9DnqHwWhoP2htA9pVuSul4sJER3KjYov9/oJHH+vXa3rrpAceqawTxO200NM8svS0Pbuz5sYizX1xmOcNiZIW3eUU/NUpsLul3u+Q05GGFSkV1fBADbU+vzKAf4pLubew6rSiEdAO4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1749136492; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=/GuYrfRIt3NP/tsfwxH5PFscLlX5erdLhDtZ3+v8kg0=; b=e51u7eqbnLxwYY5yZzmLXXP5HnH4XLEy+59bYwU7yq79RAHad1ASKDdWUvA4NKtU WuBzAfplXeyVY87JQsYejDcYPp1lcBqOWM5b+r0qfTjEoxE3JGEyEtz3kpv7NbmYyMh S0FMhUYFU5gwxET6NfPaMpw+TuQSLF2t0mAg7jGE= Received: by mx.zohomail.com with SMTPS id 1749136491036595.9387295759052; Thu, 5 Jun 2025 08:14:51 -0700 (PDT) From: Nicolas Frattaroli To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Heiko Stuebner , Sascha Hauer , Jonathan Cameron , Sebastian Reichel , Diederik de Haas Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] PM / devfreq: rockchip-dfi: add support for LPDDR5 Date: Thu, 05 Jun 2025 17:14:46 +0200 Message-ID: <4244538.aeNJFYEL58@workhorse> In-Reply-To: References: <20250530-rk3588-dfi-improvements-v1-0-6e077c243a95@collabora.com> <20250530-rk3588-dfi-improvements-v1-2-6e077c243a95@collabora.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Hello Diederik, On Wednesday, 4 June 2025 10:24:33 Central European Summer Time Diederik de Haas wrote: > Hi Nicolas, > > On Fri May 30, 2025 at 3:38 PM CEST, Nicolas Frattaroli wrote: > > [...] > > + case ROCKCHIP_DDRTYPE_LPDDR5: > > + ddrmon_ver = readl_relaxed(dfi->regs); > > + if (ddrmon_ver < 0x40) { > > + *ctrl = DDRMON_CTRL_LPDDR5 | dfi->lp5_bank_mode; > > + *mask |= DDRMON_CTRL_LP5_BANK_MODE_MASK; > > + break; > > + } > > + > > + /* > > + * As it is unknown whether the unpleasant special case > > + * behaviour used by the vendor kernel is needed for any > > + * shipping hardware, ask users to report if they have > > + * some of that hardware. > > + */ > > + dev_err(&dfi->edev->dev, > > + "unsupported DDRMON version 0x%04X, please let linux-rockchip know!\n", > > + ddrmon_ver); > > + return -EOPNOTSUPP; > > I'm guessing you mean the linux-rockchip mailing list here? If so, I > think it's better to make that explicit as 'Joe User' who may run into > this issue may not be aware of that mailing list. The 'linux' and > 'rockchip' name combo is used in quite a few places. I agree it's ambiguous, the message as it is right now is the way it is because we're not allowed to linebreak user-facing messages for grep- ability and I also don't want to exceed 100 lines of width (though this is the one case where we're allowed to). I suppose I should just replace it with the e-mail address of the list. That should be clear enough and this error message also won't end up in random boot logs strewn across the internet if it really is just some engineering sample hardware or similar that's affected. Kind regards, Nicolas Frattaroli > > Cheers, > Diederik > > > + default: > > + dev_err(&dfi->edev->dev, "unsupported memory type 0x%X\n", > > + dfi->ddr_type); > > + return -EOPNOTSUPP; > > + } > > + > > + return 0; > > +} > > + > > static int rockchip_dfi_enable(struct rockchip_dfi *dfi) > > { > > void __iomem *dfi_regs = dfi->regs; > > int i, ret = 0; > > + u32 ctrl; > > + u32 ctrl_mask; > > > > mutex_lock(&dfi->mutex); > > > > @@ -136,8 +186,11 @@ static int rockchip_dfi_enable(struct rockchip_dfi *dfi) > > >