From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 543F4C43219 for ; Mon, 29 Apr 2019 08:37:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23D9E205ED for ; Mon, 29 Apr 2019 08:37:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727554AbfD2Ihr (ORCPT ); Mon, 29 Apr 2019 04:37:47 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:42616 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727517AbfD2Ihr (ORCPT ); Mon, 29 Apr 2019 04:37:47 -0400 Received: from 79.184.254.69.ipv4.supernova.orange.pl (79.184.254.69) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.213) id e60fc47b58aa26a3; Mon, 29 Apr 2019 10:37:45 +0200 From: "Rafael J. Wysocki" To: Yue Hu Cc: "Rafael J. Wysocki" , Viresh Kumar , Rafael Wysocki , Linux PM , huyue2@yulong.com Subject: Re: [PATCH v3] cpufreq: Don't find governor for setpolicy drivers in cpufreq_init_policy() Date: Mon, 29 Apr 2019 10:37:45 +0200 Message-ID: <4262450.pcLMbF6iK3@kreacher> In-Reply-To: <20190429155640.00004adb.zbestahu@gmail.com> References: <20190429072418.7860-1-zbestahu@gmail.com> <20190429155640.00004adb.zbestahu@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Monday, April 29, 2019 9:56:40 AM CEST Yue Hu wrote: > On Mon, 29 Apr 2019 09:37:27 +0200 > "Rafael J. Wysocki" wrote: > > > On Mon, Apr 29, 2019 at 9:24 AM Yue Hu wrote: > > > > > > From: Yue Hu > > > > > > In cpufreq_init_policy() we will check if there's last_governor for target > > > and setpolicy type. However last_governor is set only if has_target() is > > > true in cpufreq_offline(). That means find last_governor for setpolicy > > > type is pointless. Also new_policy.governor will not be used if ->setpolicy > > > callback is set in cpufreq_set_policy(). > > > > > > Moreover, there's duplicate ->setpolicy check in using default policy path. > > > Let's add a new helper function to avoid it. Also update a little comment. > > > > > > Signed-off-by: Yue Hu > > > > Have you tested this with the intel_pstate driver (in the active mode)? > > No, just tested for ARM. It should be common logic from code perspective. But it is prudent to test changes on various configurations that may be affected. Testing intel_pstate shouldn't be too difficult. > Has any issue in this change? Not in principle, but I need to check the details. In general I'm a bit hesitant to take changes that haven't been tested properly. Thanks, Rafael