From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] thermal: offer TI thermal support only when ARCH_OMAP2PLUS is defined
Date: Tue, 08 Oct 2013 19:40:48 +0200 [thread overview]
Message-ID: <4296924.z1ntgL0xa6@amdc1032> (raw)
In-Reply-To: <1830886.95xXFHTq6V@amdc1032>
On Tuesday, October 08, 2013 06:59:19 PM Bartlomiej Zolnierkiewicz wrote:
[...]
> > Restricting drivers to be compiled to specific architecture is a poor
> > design strategy. Specifically, on the TI Bandgap device driver, as I
> > already mentioned to you, this is again clear, as it is currently used
> > on different archs, and the code can be easily reused when other archs,
> > different than DRA and OMAP, need it.
>
> It is the correct strategy to restrict hardware specific device drivers
> (i.e. ARM Exynos thermal driver) to be compiled only for hardware that
> it is available on (i.e. ARM Exynos SoCs). If TI bandgap driver is not
> hardware specific and can be used on non TI hardware than you're of
> course right.
Just small addition. We are not using TI bandgap IP in any current ARM
Samsung SoCs so TI bandgap IP support should not be available on them
(=> we should not use ARCH_HAS_BANDGAP at all, usage for EXYNOS_THERMAL
is incorrect as I already explained in previous mail).
OTOH archs/SoCs that are using such IP can select ARCH_HAS_BANDGAP freely.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2013-10-08 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 12:35 [PATCH] thermal: offer TI thermal support only when ARCH_OMAP2PLUS is defined Bartlomiej Zolnierkiewicz
2013-10-04 18:22 ` Eduardo Valentin
2013-10-04 18:26 ` Eduardo Valentin
2013-10-07 10:05 ` Bartlomiej Zolnierkiewicz
2013-10-07 10:51 ` Bartlomiej Zolnierkiewicz
2013-10-07 9:57 ` Bartlomiej Zolnierkiewicz
2013-10-07 10:50 ` Bartlomiej Zolnierkiewicz
2013-10-07 14:10 ` Bartlomiej Zolnierkiewicz
2013-10-08 14:47 ` Bartlomiej Zolnierkiewicz
2013-10-08 16:09 ` Eduardo Valentin
2013-10-08 16:59 ` Bartlomiej Zolnierkiewicz
2013-10-08 17:40 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4296924.z1ntgL0xa6@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=arnd@arndb.de \
--cc=eduardo.valentin@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox