Re: [PATCH] cpuidle: fix warning when compile

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Wednesday 24 of October 2012 02:14:13 Song, Youquan wrote:
> >>  	int64_t thresh = LLONG_MAX; /* Discard outliers above this value. */
> 
> >Shouldn't this one be uint64_t too?
> 
> Thanks Rafael!  Fenggung also asked me the similar question. 
> But I think, the compile only complains about do_div() at SH 32bit
> architecture, the above int64_t definition should be OK and I do not
> find any issue without changing it to uint64_t. 

OK

I fixed up the original patch.

Thanks,
Rafael


> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@sisk.pl] 
> Sent: Wednesday, October 24, 2012 8:28 AM
> To: Song, Youquan
> Cc: Wu, Fengguang; yuanhan.liu@linux.intel.com; Rik van Riel; linux-pm@vger.kernel.org; Youquan Song
> Subject: Re: [PATCH] cpuidle: fix warning when compile
> 
> On Tuesday 23 of October 2012 22:45:28 Youquan Song wrote:
> > Fix the warning complain when compile the kernel.
> > 
> > drivers/cpuidle/governors/menu.c: In function 'get_typical_interval':
> > drivers/cpuidle/governors/menu.c:268:2: warning: comparison of 
> > distinct pointer types lacks a cast [enabled by default]
> > drivers/cpuidle/governors/menu.c:277:2: warning: comparison of 
> > distinct pointer types lacks a cast [enabled by default]
> > 
> > Signed-off-by: Youquan Song <youquan.song@intel.com>
> > ---
> >  drivers/cpuidle/governors/menu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/cpuidle/governors/menu.c 
> > b/drivers/cpuidle/governors/menu.c
> > index 26d5667..2efee27 100644
> > --- a/drivers/cpuidle/governors/menu.c
> > +++ b/drivers/cpuidle/governors/menu.c
> > @@ -248,7 +248,7 @@ static enum hrtimer_restart 
> > menu_hrtimer_notify(struct hrtimer *hrtimer)  static u32 
> > get_typical_interval(struct menu_device *data)  {
> >  	int i = 0, divisor = 0;
> > -	int64_t max = 0, avg = 0, stddev = 0;
> > +	uint64_t max = 0, avg = 0, stddev = 0;
> >  	int64_t thresh = LLONG_MAX; /* Discard outliers above this value. */
> 
> Shouldn't this one be uint64_t too?
> 
> >  	unsigned int ret = 0;

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.