From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A659BC433EF for ; Sun, 8 May 2022 15:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234557AbiEHPLG convert rfc822-to-8bit (ORCPT ); Sun, 8 May 2022 11:11:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234437AbiEHPLG (ORCPT ); Sun, 8 May 2022 11:11:06 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5062ADF76; Sun, 8 May 2022 08:07:14 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nniV4-0000vT-EH; Sun, 08 May 2022 17:07:10 +0200 From: Heiko Stuebner To: Brian Norris , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Chanwoo Choi Cc: linux-kernel@vger.kernel.org, Elaine Zhang , linux-pm@vger.kernel.org, Doug Anderson , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [RFC PATCH 2/2] PM / devfreq: rk3399_dmc: Block PMU during transitions Date: Sun, 08 May 2022 17:07:09 +0200 Message-ID: <44651538.fMDQidcC6G@phil> In-Reply-To: <6c6ec0db-111c-e48f-57ce-0e444a0d168e@gmail.com> References: <20220406014842.2771799-1-briannorris@chromium.org> <582e3645-b24e-356e-7f0f-0d37bb1e32e6@gmail.com> <6c6ec0db-111c-e48f-57ce-0e444a0d168e@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Am Samstag, 7. Mai 2022, 16:21:59 CEST schrieb Chanwoo Choi: > On 22. 4. 14. 08:13, Chanwoo Choi wrote: > > On 22. 4. 14. 07:45, Heiko Stübner wrote: > >> Hi, > >> > >> Am Donnerstag, 14. April 2022, 00:14:40 CEST schrieb Chanwoo Choi: > >>> On 22. 4. 6. 10:48, Brian Norris wrote: > >>>> See the previous patch ("soc: rockchip: power-domain: Manage resource > >>>> conflicts with firmware") for a thorough explanation of the conflicts. > >>>> While ARM Trusted Firmware may be modifying memory controller and > >>>> power-domain states, we need to block the kernel's power-domain driver. > >>>> > >>>> If the power-domain driver is disabled, there is no resource conflict > >>>> and this becomes a no-op. > >>>> > >>>> Signed-off-by: Brian Norris > >>>> --- > >>>> > >>>> drivers/devfreq/rk3399_dmc.c | 13 +++++++++++++ > >>>> 1 file changed, 13 insertions(+) > >>>> > >>>> diff --git a/drivers/devfreq/rk3399_dmc.c > >>>> b/drivers/devfreq/rk3399_dmc.c > >>>> index e494d1497d60..daff40702615 100644 > >>>> --- a/drivers/devfreq/rk3399_dmc.c > >>>> +++ b/drivers/devfreq/rk3399_dmc.c > >>>> @@ -21,6 +21,7 @@ > >>>> #include > >>>> #include > >>>> +#include > >>>> #include > >>>> #include > >>>> @@ -93,6 +94,16 @@ static int rk3399_dmcfreq_target(struct device > >>>> *dev, unsigned long *freq, > >>>> mutex_lock(&dmcfreq->lock); > >>>> + /* > >>>> + * Ensure power-domain transitions don't interfere with ARM > >>>> Trusted > >>>> + * Firmware power-domain idling. > >>>> + */ > >>>> + err = rockchip_pmu_block(); > >>>> + if (err) { > >>>> + dev_err(dev, "Failed to block PMU: %d\n", err); > >>>> + goto out_unlock; > >>>> + } > >>>> + > >>>> /* > >>>> * Some idle parameters may be based on the DDR controller > >>>> clock, which > >>>> * is half of the DDR frequency. > >>>> @@ -198,6 +209,8 @@ static int rk3399_dmcfreq_target(struct device > >>>> *dev, unsigned long *freq, > >>>> dmcfreq->volt = target_volt; > >>>> out: > >>>> + rockchip_pmu_unblock(); > >>>> +out_unlock: > >>>> mutex_unlock(&dmcfreq->lock); > >>>> return err; > >>>> } > >>> > >>> Acked-by: Chanwoo Choi > >> > >> so I guess you're ok with me picking up both patches, right? > >> [Just making sure :-) ] > > > > This patch have the dependency of latest devfreq-next branch. > > So that need to make the immutable branch between rockchip and devfreq. > > > > Hi Heiko and Brian, > > Is there any other progress? > > IMHO, if rockchip maintainer reply the acked-by from patch1 > and then agree these patches to be applied to devfreq.git, > I can take them. sounds good to me. Patch1 looks good and correct to me, so I've added a Reviewed-by for it and it defintily makes sense for both to go through the devfreq tree then, so we don't need additional stable-branches :-) Thanks Heiko