From: "Eugeny S. Mints" <eugeny.mints@gmail.com>
To: David Brownell <david-b@pacbell.net>
Cc: Matthew Locke <matt@nomadgs.com>,
patrick.mochel@intel.com, linux-pm@lists.osdl.org,
sampsa.fabritius@nokia.com, linux@dominikbrodowski.net
Subject: Re: [RFC] PowerOP take 3, PowerOP core 1/5
Date: Thu, 27 Jul 2006 00:44:40 +0400 [thread overview]
Message-ID: <44C7D438.6090208@gmail.com> (raw)
In-Reply-To: <200607201501.32087.david-b@pacbell.net>
David Brownell wrote:
> On Thursday 20 July 2006 12:50 pm, Eugeny S. Mints wrote:
>
>> +static int __init powerop_init(void)
>> +{
>> + return 0;
>> +}
>> +
>> +static void __exit powerop_exit(void)
>> +{
>> +}
>> +
>> +module_init(powerop_init);
>> +module_exit(powerop_exit);
>>
>
> Best to delete useless code like that. :)
>
> And you should be grabbing that mutex to register/unregister the arch
> methods table, otherwise there's little point in having it ...
>
basically agree. The reference code is handling only one arch layer
(essentially PM core) underneath PowerOP for the time being though.
At the same time PM Core is expected to be "aware" of all PM related
parameters and details so I actually would like to see an use case showing
when an extra layer below PowerOP may be useful to continue moving
towards multi arch layer approach.
Thanks,
Eugeny
next prev parent reply other threads:[~2006-07-26 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 19:50 [RFC] PowerOP take 3, PowerOP core 1/5 Eugeny S. Mints
2006-07-20 22:01 ` David Brownell
2006-07-26 20:44 ` Eugeny S. Mints [this message]
2006-07-27 0:18 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C7D438.6090208@gmail.com \
--to=eugeny.mints@gmail.com \
--cc=david-b@pacbell.net \
--cc=linux-pm@lists.osdl.org \
--cc=linux@dominikbrodowski.net \
--cc=matt@nomadgs.com \
--cc=patrick.mochel@intel.com \
--cc=sampsa.fabritius@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox