Re: PowerOP, Whatchanged/Issues/TODO 2/2

["Eugeny S. Mints" <eugeny.mints@gmail.com>]

Greg,

Greg KH wrote:
> On Sat, Sep 02, 2006 at 07:16:01PM +0400, Eugeny S. Mints wrote:
>> whatchanged:
>> - optional sysfs interface is added
>> - code is moved under kernel/power
>> - Greg's comments on kobject and coding style are addressed
>>
>> todo/issues:
>> - better implementation for getting registered operating point names
>> - move string parsing into powerop generic code
>> - configfs for operating points creation from user space
> 
> You forgot:
>   - Handle module referencing counting issues.
i'm discussing this and other issues you pointed out in a separate email.
> 
> Also, no #ifdefs in the .c code please, that debugging stuff doesn't
> have to look like that,
do you mean CONFIG_POWEROP_SYSFS_OP_DEBUG_IF? Probably it's not a good name but 
it's not a debugging code. it could be CONFIG_POWEROP_SYSFS_OP_HW_IF - this 
special HW point might be useful in a production code.

Eugeny
> break it out into separate functions to keep the
> codepath clean.
> 
> thanks,
> 
> greg k-h
>