From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eugeny S. Mints" Subject: Re: PowerOP, Whatchanged/Issues/TODO 2/2 Date: Sun, 03 Sep 2006 03:13:03 +0400 Message-ID: <44FA0FFF.9020807@gmail.com> References: <44F9A031.8020203@gmail.com> <20060902183351.GC31197@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20060902183351.GC31197@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: Greg KH Cc: pm list List-Id: linux-pm@vger.kernel.org Greg, Greg KH wrote: > On Sat, Sep 02, 2006 at 07:16:01PM +0400, Eugeny S. Mints wrote: >> whatchanged: >> - optional sysfs interface is added >> - code is moved under kernel/power >> - Greg's comments on kobject and coding style are addressed >> >> todo/issues: >> - better implementation for getting registered operating point names >> - move string parsing into powerop generic code >> - configfs for operating points creation from user space > = > You forgot: > - Handle module referencing counting issues. i'm discussing this and other issues you pointed out in a separate email. > = > Also, no #ifdefs in the .c code please, that debugging stuff doesn't > have to look like that, do you mean CONFIG_POWEROP_SYSFS_OP_DEBUG_IF? Probably it's not a good name= but = it's not a debugging code. it could be CONFIG_POWEROP_SYSFS_OP_HW_IF - this = special HW point might be useful in a production code. Eugeny > break it out into separate functions to keep the > codepath clean. > = > thanks, > = > greg k-h > =