From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [RFC 3/8] cpufreq: imx6q: Set max suspend_freq to avoid changes during suspend Date: Tue, 28 Mar 2017 22:50:50 +0200 Message-ID: <45185440.SBt0mf6LXq@aspire.rjw.lan> References: <20170323043427.GE12094@vireshk-i7> <1490731431.15830.9.camel@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1490731431.15830.9.camel@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Leonard Crestez Cc: Mark Rutland , devicetree@vger.kernel.org, Anson Huang , Irina Tirdea , Viresh Kumar , linux-pm@vger.kernel.org, Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Mark Brown , Octavian Purdila , Sascha Hauer , Fabio Estevam , Robin Gong , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: linux-pm@vger.kernel.org On Tuesday, March 28, 2017 11:03:51 PM Leonard Crestez wrote: > On Thu, 2017-03-23 at 10:04 +0530, Viresh Kumar wrote: > > On 22-03-17, 18:53, Leonard Crestez wrote: > > > If the cpufreq driver tries to modify voltage/freq during suspend/resume > > > it might need to control an external PMIC via I2C or SPI but those > > > devices might be already suspended. > > > > > > To avoid this scenario we just increase cpufreq to highest setpoint > > > before suspend. This issue can easily be triggered by ldo-bypass but in > > > theory any regulator set_voltage call can end up having to modify > > > external supply voltages. > > > > > > Signed-off-by: Leonard Crestez > > > --- > > > drivers/cpufreq/imx6q-cpufreq.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Acked-by: Viresh Kumar > > The first couple of patches are obvious fixes despite being marked as > RFC. It would be great if you could apply them to your tree separately Why? > from the rest of the series but I'm not sure what the process is here. Well, you have to talk to me. Thanks, Rafael