From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org
Subject: Re: drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static?
Date: Fri, 11 Jan 2013 23:47:15 +0100 [thread overview]
Message-ID: <4518630.CgYC5fVtRj@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohponzGnFdzAk0PzTsvrt9PA2OH1Aaa9VQh4+En3KdGbJwFA@mail.gmail.com>
On Friday, January 11, 2013 07:38:26 PM Viresh Kumar wrote:
> On 11 January 2013 19:33, Fengguang Wu <fengguang.wu@intel.com> wrote:
> > FYI, there are new sparse warnings show up in
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
> > head: f3bb59ab652c781155b1c5e42ef7e29bf936d86b
> > commit: 536ff06aba714c1d2d53cfca86b1a2e455842387 cpufreq: Don't use cpu removed during cpufreq_driver_unregister
> > date: 15 hours ago
> >
> > drivers/cpufreq/cpufreq.c:43:8: sparse: symbol 'cpufreq_cpu_data' was not declared. Should it be static?
> > drivers/cpufreq/cpufreq.c:46:8: sparse: symbol 'cpufreq_cpu_governor' was not declared. Should it be static?
> >>> drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static?
> > drivers/cpufreq/cpufreq.c:72:8: sparse: symbol 'cpufreq_policy_cpu' was not declared. Should it be static?
> > drivers/cpufreq/cpufreq.c:73:8: sparse: symbol 'cpu_policy_rwsem' was not declared. Should it be static?
> >
> > Please consider folding the attached diff :-)
>
> Thanks for the fix :)
> @Rafael: I hope you can apply that?
I could, but I prefer you to send me a fixed patch. :-)
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-01-11 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50f017f7.SoVcNexmm6uNvfQX%yuanhan.liu@linux.intel.com>
2013-01-11 14:03 ` drivers/cpufreq/cpufreq.c:51:17: sparse: symbol 'cpufreq_online_mask' was not declared. Should it be static? Fengguang Wu
2013-01-11 14:08 ` Viresh Kumar
2013-01-11 22:47 ` Rafael J. Wysocki [this message]
2013-01-12 4:08 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4518630.CgYC5fVtRj@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=fengguang.wu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox