linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Javi Merino <javi.merino@arm.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: 최찬우 <cw00.choi@samsung.com>, 박경민 <kyungmin.park@samsung.com>
Subject: Re: [PATCH v3 1/3] PM / devfreq: cache the last call to get_dev_status()
Date: Mon, 03 Aug 2015 05:30:54 +0000 (GMT)	[thread overview]
Message-ID: <453349609.343761438579853672.JavaMail.weblogic@epmlwas06d> (raw)

> The return value of get_dev_status() can be reused.  Cache it so that
> other parts of the kernel can reuse it instead of having to call the
> same function again.
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Javi Merino <javi.merino@arm.com>

Your patch introduces build errors if you try to compile governors as
modules. Please fix it.


And..
> +int devfreq_update_stats(struct devfreq *df)
> +{
> +	return df->profile->get_dev_status(df->dev.parent, &df->last_status);
> +}
This seems a good candidate for a macro or a static inline function.

Modifications in governor_simpleondemand.c looks good.


Please add some explanations at the definition of devfreq_update_stats()
as well in devfreq.c


Cheers,
MyungJoo.


             reply	other threads:[~2015-08-03  5:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  5:30 MyungJoo Ham [this message]
2015-08-03 15:24 ` [PATCH v3 1/3] PM / devfreq: cache the last call to get_dev_status() Javi Merino
  -- strict thread matches above, loose matches on Subject: below --
2015-07-28 15:17 [PATCH v3 0/3] Devfreq cooling device Javi Merino
2015-07-28 15:17 ` [PATCH v3 1/3] PM / devfreq: cache the last call to get_dev_status() Javi Merino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453349609.343761438579853672.JavaMail.weblogic@epmlwas06d \
    --to=myungjoo.ham@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=javi.merino@arm.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).