public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
	Andrew Morton <akpm@osdl.org>, "Brown, Len" <len.brown@intel.com>,
	"Lebedev, Vladimir P" <vladimir.p.lebedev@intel.com>,
	linux-pm@osdl.org
Subject: [PATCH] Fix swsusp-change-code-order-in-diskc.patch
Date: Thu, 25 Jan 2007 15:36:38 +0300	[thread overview]
Message-ID: <45B8A456.2010301@linux.intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi,

Recent patch from Rafael changed the order of platform_prepare() and
swsusp_read(). platform_prepare() should happen before swsusp_read()
in order to get nice LED blinking during load of the image and time for
GPE activity to settle down.

Attaching the patch to fix order.
Regards,
    Alex.

[-- Attachment #2: fix-swsusp-change-code-ordering-in-diskc.patch --]
[-- Type: text/plain, Size: 1150 bytes --]

Recent patch from Rafael changed the order of platform_prepare() and 
swsusp_read(). platform_prepare() should happen before swsusp_read()
in order to get nice LED blinking during load of the image and time for
GPE activity to settle down.

From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>

LED blinking and time for GPE activity to stop.
---

 kernel/power/disk.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index 33e67b4..406b20a 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -240,21 +240,22 @@ static int software_resume(void)
 		goto Done;
 	}
 
-	pr_debug("PM: Reading swsusp image.\n");
-
-	error = swsusp_read();
+	error = platform_prepare();
 	if (error) {
 		swsusp_free();
 		goto Thaw;
 	}
 
-	pr_debug("PM: Preparing devices for restore.\n");
+	pr_debug("PM: Reading swsusp image.\n");
 
-	error = platform_prepare();
+	error = swsusp_read();
 	if (error) {
 		swsusp_free();
 		goto Thaw;
 	}
+
+	pr_debug("PM: Preparing devices for restore.\n");
+
 	suspend_console();
 	error = device_suspend(PMSG_PRETHAW);
 	if (error)

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2007-01-25 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 12:36 Alexey Starikovskiy [this message]
2007-01-25 12:43 ` [PATCH] Fix swsusp-change-code-order-in-diskc.patch Pavel Machek
2007-01-25 12:51   ` Alexey Starikovskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45B8A456.2010301@linux.intel.com \
    --to=alexey.y.starikovskiy@linux.intel.com \
    --cc=akpm@osdl.org \
    --cc=len.brown@intel.com \
    --cc=linux-pm@osdl.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=vladimir.p.lebedev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox