Re: [PATCH] Fix swsusp-change-code-order-in-diskc.patch

Pavel Machek
2007-01-25T12:43:25Z

Hi!

> Recent patch from Rafael changed the order of platform_prepare() and
> swsusp_read(). platform_prepare() should happen before swsusp_read()
> in order to get nice LED blinking during load of the image and time for
> GPE activity to settle down.

Well, looks acceptable to me.

But if GPEs need some time to settle down, that should be done
explicitely, and with _big_ comment? What if your disk is too fast?

Also, same problem is likely present in uswsusp (and harder to fix
there). Is this really required?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html