Re: [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access

Vivek Goyal
2007-03-15T11:41:41Z

On Wed, Mar 14, 2007 at 10:46:47PM +0100, Andi Kleen wrote:
> Tejun Heo <htejun@gmail.com> writes:
> >
> > Let's assume there's a device which shares its INTX IRQ line with
> > another device and the other one is already initialized. During boot,
> > due to BIOS's fault, bad hardware design or sheer bad luck, the device
> > has got a pending IRQ.
>
> This seems to be also common after kexec during kexec crashdumps
> where the device just continues doing what it did before the crash.
>

That's true. It happens very frequently in kdump case where underlying device
can very well have pending interrupts while second kernel is booting.
Currently we allow the kernel to disable that irq line and we boot the kernel
with "irqpoll" so that device still operates in polling mode.

But getting this fixed will help. If device interrupts are enabled only after
driver has had a chance to reset the device, things will be better, at least
from kdump perspective.

Thanks
Vivek