Re: Alternative Concept [Was: Re: [RFC] CPUFreq PowerOP integration, Intro 0/3]

Pavel Machek
2006-10-12T16:48:13Z

On Thu 2006-10-12 08:38:21, Mark Gross wrote:
> On Sun, Oct 08, 2006 at 07:16:49AM +0000, Pavel Machek wrote:
> > Hi!
> >
> > > F) So, how would this work for OMAP1?
> > >
> > > Let's limit it, to keep it somewhat simple, to the values contained in your
> > > "struct pm_core_point" for OMAP:
> > >
> > > int cpu_vltg; /* voltage in mV */
> > > int dpll; /* in KHz */
> > > int cpu; /* CPU frequency in KHz */
> > > int tc; /* in KHz */
> > > int per; /* in KHz */
> > > int dsp; /* in KHz */
> > > int dspmmu; /* in KHz */
> > > int lcd; /* in KHz */
> > >
> > > and let's also add a
> > >
> > > int i_am_special;
> >
> > Hehe, nice idea.
> >
> > > I think that this might be much easier to implement than your PowerOP /
> > > operating points / PM core / PowerOP - cpufreq interaction patches. As a
> > > matter of fact, some parts of your operating points table infrastructure
> > > may be usable for the concept outlined above. So, what do you think? What
> > > does everyone else involved think about this alternative approach?
> >
> > Looks okay to me. Unlike powerop design, this actually works for
> > everyone.
>
> Pavel, if you would pay attention better you would notice that at the
> underneath of what Dominic is talking about is a concept of *more knobs*
> for controlling platform power states. This is what PowerOP is trying
> to bring to the table.

I believe I did pay attention. What PowerOP has is crappy patches,
crappy changelogs, and when you don't like it, you are obviously
biased (or not paying attention).

And no, what Dominik describes is very reasonable, unlike powerop.

> PowerOP is not a policy engine like what Dominic is talking about. And
> what Dominic is talking about will need to build on something that will
> end up looking so much like power op that it wont be funny.

Great, so you think you do not have that much work to do. Go ahead and
do it.

(Unlike powerop, this has actually chance of working with 256
cpus. Unlike powerop people, Dominik did his homework.)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html