Re: [PATCH v4] pm_ops: add system quiesce/activate hooks

Johannes Berg
2007-04-13T21:06:08Z

[-- Attachment #1.1: Type: text/plain, Size: 1343 bytes --]

On Fri, 2007-04-13 at 22:58 +0200, Pavel Machek wrote:

> That it is same old hack it used to be. There's nothing magic about
> decrementer, and I do not think it is _neccessary_ to touch it just
> before cli. Just disable it from sysdev handler or something.

No, you cannot disable it from sysdev handler because you have to be
able to take interrupts. Can we *please* move on to some more productive
discussion?

> > > --- wireless-dev.orig/include/linux/pm.h 2007-04-13 10:09:17.835356880 +0200
> > > +++ wireless-dev/include/linux/pm.h 2007-04-13 14:57:01.525356880 +0200
> > > @@ -135,9 +135,19 @@ typedef int __bitwise suspend_disk_metho
> > > * @prepare: Prepare the platform for the given suspend state. Can return a
> > > * negative error code if necessary.
> > > *
> > > + * @quiesce: This callback is called after devices are suspended but before
> > > + * they are powered down. If assigned, this callback must at least turn
> > > + * off local IRQs. If left unassigned, a default callback that does
> > > + * nothing but turn off local IRQs is assigned during pm_set_ops().
>
> Is it called for s2ram? swsusp? uswsusp?

Whoops, I had that in an earlier version, it's not supposed to be called
for (u)swsusp because pm_ops involvement there is a hack anyway. I'll
fix the description.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]