Re: [PATCH v4] pm_ops: add system quiesce/activate hooks

Pavel Machek
2007-04-13T22:39:22Z

On Sat 2007-04-14 08:25:22, Benjamin Herrenschmidt wrote:
>
> > Hmm, I missed that. :-(
> >
> > I think we need to make things clear: Either we add the additional hooks to
> > pm_ops in which case they should be taken into account in the (u)swsusp code
> > too, or we don't add them at all.
> >
> > Well, there also is one more solution. Namely, we can add the hooks to pm_ops
> > and make (u)swsusp use something else instead of pm_ops, but that would require
> > some more consideration.
>
> Well, what would be nice would be if swsusp wasn't just such a gross
> contraption completely bypassing the rest of the suspend/resume
> framework...

Great, so:

* you claim that current code is hacked up

* I claim, that if I apply the patch, the result will be ugly hack.

Good; I think you agree that Johaness' patch certainly does not fix
the uglyness of current code.

=> we both agree that after applying the patch, we'll have hacked-up
code. So... can we do some cleanups before hacking on it more?

If sysdevs need ordering, lets add ordering. If platform devices need
ordering, lets do it. If acpi S4 should not be using pm_ops, we should
probably fix that. If swsusp should not be called from pm_ops, we can
probably change that (but we need to keep userland interface).

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html