Re: [PATCH v2] pm_ops: add system quiesce/activate hooks

Rafael J. Wysocki
2007-04-12T10:45:58Z

On Thursday, 12 April 2007 12:16, Pavel Machek wrote:
> Hi!
>
> > > I doubt your reasoning is cogent enough. If you add such a global thing,
> > > you should prove it, or clearly explain what is the thing for.
> > > I don't believe that it's not possible to solve that decrementer case
> > > without this change. Can't you add appropriate platform_device which
> > > would register early enough, to meet that timing requirement when it
> > > gets suspended?
> >
> > That's would be absolutely disgusting... (relying on magic ordering of
> > platform devices).
>
> Adding platform hook to disable interrupts just because we need one
> platform device last is not nice, either. (And does decrementer even
> need to come last?)
>
> Anyway, platform devices may need specific ordering on more than power
> pc, so perhaps we should just make ordering more stable so that
> relying on it is no longer a hack?

I second that, although I think it also would be a global change.

Greetings,
Rafael