Re: [PATCH v2] pm_ops: add system quiesce/activate hooks

Dmitry Krivoschekov
2007-04-11T20:47:09Z

Hi Johannes,

Johannes Berg wrote:
> For powermac, we need to do some things between suspending devices and
> device_power_off, for example setting the decrementer.
I doubt your reasoning is cogent enough. If you add such a global thing,
you should prove it, or clearly explain what is the thing for.
I don't believe that it's not possible to solve that decrementer case
without this change. Can't you add appropriate platform_device which
would register early enough, to meet that timing requirement when it
gets suspended?

>
>
> --- wireless-dev.orig/arch/powerpc/platforms/powermac/setup.c 2007-04-11 17:07:51.029481358 +0200
> +++ wireless-dev/arch/powerpc/platforms/powermac/setup.c 2007-04-11 17:10:53.659481358 +0200
> @@ -475,7 +475,9 @@ static int pmac_pm_valid(suspend_state_t
> static struct pm_ops pmac_pm_ops = {
> .pm_disk_mode = PM_DISK_SHUTDOWN,
> .prepare = pmac_pm_prepare,
> + .quiesce = pm_default_quiesce,
> .enter = pmac_pm_enter,
> + .activate = pm_default_activate,
> .finish = pmac_pm_finish,
> .valid = pmac_pm_valid,
> };

So, where is that callbacks that are so desirable for powermac?

Thanks,
Dmitry