Re: [PATCH v4] pm_ops: add system quiesce/activate hooks

Rafael J. Wysocki
2007-04-13T22:18:06Z

On Friday, 13 April 2007 23:59, Johannes Berg wrote:
> On Fri, 2007-04-13 at 23:52 +0200, Pavel Machek wrote:
>
> > Look again, this sequence is before taking system snapshot, and then
> > we have to recover and save the snapshot, too.
>
> I know. But that doesn't make us care.
>
> As I explained previously, the decrementer exception is pending until it
> is taken. It doesn't matter one bit whether it is pending during the
> snapshot, but it does matter if we need the CPU to go to sleep later
> because it won't when the exception is pending.

Technically, they may be not needed by (u)swsusp, but since (u)swsusp already
uses pm_ops in the platform mode, it formally should use these new hooks in
the platform mode too. Otherwise it won't make sense to use pm_ops in
(u)swsusp at all, IMHO.

Greetings,
Rafael