Re: [PATCH v4] pm_ops: add system quiesce/activate hooks

Johannes Berg
2007-04-13T21:18:05Z

[-- Attachment #1.1: Type: text/plain, Size: 718 bytes --]

On Fri, 2007-04-13 at 23:12 +0200, Pavel Machek wrote:

> > Whoops, I had that in an earlier version, it's not supposed to be called
> > for (u)swsusp because pm_ops involvement there is a hack anyway. I'll
> > fix the description.
>
> But (u)swsusp needs to shut down the devices, and it does both suspend
> and powerdown, too...?

Yes, but the special S4 state is just hacked onto pm_ops, nothing but
ACPI S4 will ever sanely use pm_ops. If I'd invented pm_ops I'd made
pm_ops solely for suspend to ram/standby/... and added a *separate* hook
for pm_disk_mode and S4 because logically that really doesn't belong to
pm_ops which does almost exclusively things for suspend to ram/standby.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]