Re: [PATCH v2] pm_ops: add system quiesce/activate hooks

Pavel Machek
2007-04-13T21:00:23Z

Hi!

> > Adding platform hook to disable interrupts just because we need one
> > platform device last is not nice, either. (And does decrementer even
> > need to come last?)
>
> But the hack is classifying the decrementer as a platform device in the
> first place. And then we'd still need to have one platform device and
> one sysdev since we want to wake up the decrementer before enabling
> IRQs

Can decrementer be waked a little later?

> but set it to a high value before disabling IRQs. Or we'd need some sort
> of special foo device that has hooks both before and after and comes
> last/first, just for one user?

Have two devices, then.

> Besides, we can always rewrite it later when somebody introduces a foo
> device that fits above model. Since this patch essentially changes
> nothing, I'd been hoping to get it into .22 so we can finally start

No. Hacks like this are impossible to get rid of.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html