Re: [PATCH v4] pm_ops: add system quiesce/activate hooks

Johannes Berg
2007-04-13T22:01:47Z

[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]

On Fri, 2007-04-13 at 23:56 +0200, Pavel Machek wrote:

> There are about 7 places where we do stop_platform_devices()
> local_irq_disable() stop_sysdevs().

I can only find three of those.

> You call your hook from one of
> them and I suspect you need to call it from more than one. Plus, the
> hook needs to have documented semantics, so people know if they should
> do local_irq_disable() or if they should call your hook.

All but one are related to suspend to disk. I don't see anybody
inventing yet another entry point to the kernel that actually uses
pm_ops internally, but if they do surely they'll follow the code that is
there.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]