Re: [PATCH v4] pm_ops: add system quiesce/activate hooks

Pavel Machek
2007-04-13T22:16:52Z

On Sat 2007-04-14 00:13:26, Johannes Berg wrote:
> On Sat, 2007-04-14 at 00:09 +0200, Rafael J. Wysocki wrote:
>
> > Hmm, I missed that. :-(
> >
> > I think we need to make things clear: Either we add the additional hooks to
> > pm_ops in which case they should be taken into account in the (u)swsusp code
> > too, or we don't add them at all.
>
> I can do that. I don't care one bit since I will never use pm_ops for
> suspend to disk anyway.

Please don't do that just yet.

I see ppc as being really special here.

Normally, preparation for s2ram and preparation for snapshot is really
similar, but you have exception to that rule. I do think clean
solution is redesigning plaform/sysdevs to have stable order.

If you added one platform and one sysdev, would that _work_? AFAICT
you say it would and Ben says it would not. (Lets leave uglyness
debate for later).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html