From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Alan Stern <stern@rowland.harvard.edu>,
Linux PM list <linux-pm@vger.kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Aaron Lu <aaron.lu@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kevin Hilman <khilman@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [RFC][PATCH 0/3] PM / sleep: Avoid resuming runtime-suspended devices during system suspend
Date: Tue, 13 May 2014 03:02:05 +0200 [thread overview]
Message-ID: <4649019.is79p6EySp@vostro.rjw.lan> (raw)
Hi All,
We've discussed that at length here:
http://marc.info/?t=139950469000003&r=1&w=4
but I'm starting a new thread to refresh things a bit.
This is about adding a mechanism allowing us to avoid runtime-suspended
devices during system suspend. The reason why it has to touch the PM core
is because that needs to be coordinated across the device hierarchy.
The idea is to add a new device PM flag and to modify the PM core as follows.
- If ->prepare() returns a positive number for a device, that means "this
device is runtime-suspended and you can leave it like that if you do the
same for all of its descendants".
- If that happens, the PM core sets the new flag for the device in
question *if* the device is indeed runtime-suspended *and* *if*
the transition is a suspend (and not hibernation, for example).
Otherwise, it clears the flag for the device. All of that happens in
device_prepare().
- In __device_suspend() the PM core clears the new flag for the device's
parent if it is clear for the device to ensure that the flag will only
be set for a device if it is also set for all of its descendants.
- PM core skips ->suspend/late/noirq and ->resume/early/noirq for all devices
having the flag set - so the flag can be called "direct_complete" as it
causes the PM core to go directy for the ->complete() callback when set.
- The ->complete() callback has to check direct_complete if ->prepare()
returned a positive number previously and is responsible for further
handling of the device.
That is introduced by patch [2/3].
To simplify things slightly it is helpful to move the invocation of
pm_runtime_barrier() from __device_suspend() to device_prepare(), but still
under pm_runtime_get_noresume() beforehand (patch [1/3]).
Patch [3/3] shows how this can be used by adding support for it to the ACPI
PM comain.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next reply other threads:[~2014-05-13 1:02 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 1:02 Rafael J. Wysocki [this message]
2014-05-13 1:03 ` [RFC][PATCH 1/3] PM / sleep: Move runtime PM barrier invocation to device_prepare() Rafael J. Wysocki
2014-05-13 9:16 ` Ulf Hansson
2014-05-13 10:35 ` Rafael J. Wysocki
2014-05-13 10:59 ` Ulf Hansson
2014-05-13 15:07 ` Rafael J. Wysocki
2014-05-13 15:19 ` Rafael J. Wysocki
2014-05-13 1:10 ` [RFC][PATCH 2/3] PM / sleep: Mechanism to avoid resuming runtime-suspended devices unnecessarily Rafael J. Wysocki
2014-05-13 9:30 ` Ulf Hansson
2014-05-13 14:49 ` Alan Stern
2014-05-13 15:13 ` Rafael J. Wysocki
2014-05-13 15:12 ` Alan Stern
2014-05-13 15:43 ` Rafael J. Wysocki
2014-05-13 15:46 ` Alan Stern
2014-05-13 16:16 ` Rafael J. Wysocki
2014-05-13 16:19 ` Alan Stern
2014-05-13 21:29 ` Rafael J. Wysocki
2014-05-14 14:53 ` Alan Stern
2014-05-15 11:13 ` Rafael J. Wysocki
2014-05-16 0:45 ` [PATCH 0/3] (was: Re: PM / sleep: Mechanism to avoid resuming runtime-suspended devices unnecessarily) Rafael J. Wysocki
2014-05-16 0:46 ` [PATCH 1/3] PM / sleep: Mechanism to avoid resuming runtime-suspended devices unnecessarily Rafael J. Wysocki
2014-05-16 14:27 ` Alan Stern
2014-05-16 21:10 ` Rafael J. Wysocki
2014-05-16 0:47 ` [PATCH 2/3] PM / sleep: Update device PM documentation to cover direct_complete Rafael J. Wysocki
2014-05-16 0:48 ` [PATCH 3/3][Resend] ACPI / PM: Avoid resuming devices in ACPI PM domain during system suspend Rafael J. Wysocki
2014-05-16 22:18 ` [PATCH 3/3][update] " Rafael J. Wysocki
2014-05-15 12:06 ` [RFC][PATCH 2/3] PM / sleep: Mechanism to avoid resuming runtime-suspended devices unnecessarily Ulf Hansson
2014-05-15 12:55 ` Rafael J. Wysocki
2014-05-15 17:35 ` Kevin Hilman
2014-05-14 22:24 ` Jacob Pan
2014-05-15 11:11 ` Rafael J. Wysocki
2014-05-15 13:09 ` Jacob Pan
2014-05-15 14:29 ` Alan Stern
2014-05-15 7:03 ` Jacob Pan
2014-05-15 15:58 ` Alan Stern
2014-05-16 15:20 ` Jacob Pan
2014-05-16 21:08 ` Rafael J. Wysocki
2014-05-19 9:18 ` Jacob Pan
2014-05-19 19:53 ` Alan Stern
2014-05-19 20:13 ` Rafael J. Wysocki
2014-05-19 20:20 ` Rafael J. Wysocki
2014-05-13 1:10 ` [RFC][PATCH 3/3] ACPI / PM: Avoid resuming devices in ACPI PM domain during system suspend Rafael J. Wysocki
2014-05-13 14:45 ` [RFC][PATCH 0/3] PM / sleep: Avoid resuming runtime-suspended devices " Alan Stern
2014-05-13 15:25 ` Rafael J. Wysocki
2014-05-13 15:25 ` Alan Stern
2014-05-13 15:46 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4649019.is79p6EySp@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=aaron.lu@intel.com \
--cc=khilman@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).