From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] sata_promise: use TF interface for polling NODATA commands Date: Wed, 06 Jun 2007 19:19:28 +0900 Message-ID: <46668A30.2040907@suse.de> References: <46608E3F.4060201@dgreaves.com> <200706012342.45657.rjw@sisk.pl> <46609FAD.7010203@dgreaves.com> <200706020122.49989.rjw@sisk.pl> <4661EFBB.5010406@dgreaves.com> <4662D852.4000005@dgreaves.com> <46667160.80905@gmail.com> <20070606101837.GC29122@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070606101837.GC29122@htj.dyndns.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Tejun Heo Cc: netdev@oss.sgi.com, mikpe@it.uu.se, Neil Brown , David Greaves , linux-pm , "'linux-kernel@vger.kernel.org'" , xfs@oss.sgi.com, Linus Torvalds List-Id: linux-pm@vger.kernel.org Tejun Heo wrote: > sata_promise uses two different command modes - packet and TF. Packet > mode is intelligent low-overhead mode while TF is the same old > taskfile interface. As with other advanced interface (ahci/sil24), > ATA_TFLAG_POLLING has no effect in packet mode. However, PIO commands > are issued using TF interface in polling mode, so pdc_interrupt() > considers interrupts spurious if ATA_TFLAG_POLLING is set. > > This is broken for polling NODATA commands because command is issued > using packet mode but the interrupt handler ignores it due to > ATA_TFLAG_POLLING. Fix pdc_qc_issue_prot() such that ATA/ATAPI NODATA > commands are issued using TF interface if ATA_TFLAG_POLLING is set. > > This patch fixes detection failure introduced by polling SETXFERMODE. > > Signed-off-by: Tejun Heo Eeeek... Wrong thread. Please ignore this posting. Will repost. Sorry. -- tejun