From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Greaves Subject: Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume Date: Fri, 29 Jun 2007 08:40:00 +0100 Message-ID: <4684B750.5030001@dgreaves.com> References: <46744065.6060605@dgreaves.com> <200706281727.35430.rjw@sisk.pl> <20070628220045.GA4521@elf.ucw.cz> <200706290016.45719.rjw@sisk.pl> <20070629050024.GO31489@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070629050024.GO31489@sgi.com> Sender: linux-raid-owner@vger.kernel.org To: David Chinner Cc: "Rafael J. Wysocki" , Pavel Machek , linux-pm , "'linux-kernel@vger.kernel.org'" , xfs@oss.sgi.com, LinuxRaid , LVM general discussion and development , David Robinson , Oleg Nesterov List-Id: linux-pm@vger.kernel.org David Chinner wrote: > On Fri, Jun 29, 2007 at 12:16:44AM +0200, Rafael J. Wysocki wrote: >> There are two solutions possible, IMO. One would be to make these workqueues >> freezable, which is possible, but hacky and Oleg didn't like that very much. >> The second would be to freeze XFS from within the hibernation code path, >> using freeze_bdev(). > > The second is much more likely to work reliably. If freezing the > filesystem leaves something in an inconsistent state, then it's > something I can reproduce and debug without needing to > suspend/resume. > > FWIW, don't forget you need to thaw the filesystem on resume. I've been a little distracted recently - sorry. I'll re-read the thread and see if there are any test actions I need to complete. I do know that the corruption problems I've been having: a) only happen after hibernate/resume b) only ever happen on one of 2 XFS filesystems c) happen even when the script does xfs_freeze;sync;hibernate;xfs_thaw What happens if a filesystem is frozen and I hibernate? Will it be thawed when I resume? David