From: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Yan <andy.yan@rock-chips.com>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Konrad Dybcio <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Vinod Koul <vkoul@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Stephen Boyd <swboyd@chromium.org>,
Andre Draszik <andre.draszik@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Elliot Berman <quic_eberman@quicinc.com>,
Srinivas Kandagatla <srini@kernel.org>
Subject: Re: [PATCH v14 01/10] power: reset: reboot-mode: Synchronize list traversal
Date: Wed, 17 Sep 2025 22:36:22 +0530 [thread overview]
Message-ID: <472265f5-8463-e0ed-6386-f52478d4f2fd@oss.qualcomm.com> (raw)
In-Reply-To: <7eqa3rs3nvy7htvrkwyh5m7ok34n6c3h2dxn7xm2abdjzav4hp@i275ed4owgru>
On 9/17/2025 12:14 AM, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Aug 15, 2025 at 08:05:06PM +0530, Shivendra Pratap wrote:
>> List traversals must be synchronized to prevent race conditions
>> and data corruption. The reboot-mode list is not protected by a
>> lock currently, which can lead to concurrent access and race.
>>
>> Introduce a mutex lock to guard all operations on the reboot-mode
>> list and ensure thread-safe access. The change prevents unsafe
>> concurrent access on reboot-mode list.
>>
>> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
>> ---
>
> This should use scoped_guard() and a Fixes: tag. Otherwise LGTM.
ACK. Will update this patch based on scoped_guard() and add a Fixes tag.
thanks,
Shivendra
next prev parent reply other threads:[~2025-09-17 17:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 14:35 [PATCH v14 00/10] Implement vendor resets for PSCI SYSTEM_RESET2 Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 01/10] power: reset: reboot-mode: Synchronize list traversal Shivendra Pratap
2025-09-16 18:44 ` Sebastian Reichel
2025-09-17 17:06 ` Shivendra Pratap [this message]
2025-08-15 14:35 ` [PATCH v14 02/10] power: reset: reboot-mode: Add device tree node-based registration Shivendra Pratap
2025-09-16 18:48 ` Sebastian Reichel
2025-09-17 16:29 ` Shivendra Pratap
2025-09-17 22:32 ` Sebastian Reichel
2025-09-18 17:19 ` Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 03/10] power: reset: reboot-mode: Add support for 64 bit magic Shivendra Pratap
2025-08-28 13:22 ` Casey Connolly
2025-09-02 9:55 ` Shivendra Pratap
2025-09-02 14:20 ` Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 04/10] Documentation: ABI: Add sysfs-class-reboot-mode-reboot_modes Shivendra Pratap
2025-09-16 18:51 ` Sebastian Reichel
2025-08-15 14:35 ` [PATCH v14 05/10] power: reset: reboot-mode: Expose sysfs for registered reboot_modes Shivendra Pratap
2025-09-16 19:02 ` Sebastian Reichel
2025-09-17 2:56 ` Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 06/10] dt-bindings: arm: Document reboot mode magic Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 07/10] firmware: psci: Implement vendor-specific resets as reboot-mode Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 08/10] arm64: dts: qcom: qcm6490-idp: Add PSCI SYSTEM_RESET2 types Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 09/10] arm64: dts: qcom: qcs6490-rb3gen2: " Shivendra Pratap
2025-08-15 14:35 ` [PATCH v14 10/10] arm64: dts: qcom: lemans-ride: " Shivendra Pratap
2025-08-15 21:22 ` [PATCH v14 00/10] Implement vendor resets for PSCI SYSTEM_RESET2 Florian Fainelli
2025-08-28 8:05 ` Kathiravan Thirumoorthy
2025-09-02 13:10 ` Shivendra Pratap
2025-09-02 15:05 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472265f5-8463-e0ed-6386-f52478d4f2fd@oss.qualcomm.com \
--to=shivendra.pratap@oss.qualcomm.com \
--cc=Souvik.Chakravarty@arm.com \
--cc=andersson@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=andy.yan@rock-chips.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=florian.fainelli@broadcom.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=quic_eberman@quicinc.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=srini@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox