* [PATCH v1] ACPI: property: Use acpi_dev_parent()
@ 2022-08-29 16:12 Rafael J. Wysocki
2022-08-29 17:00 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-08-29 16:12 UTC (permalink / raw)
To: Linux ACPI; +Cc: LKML, Andy Shevchenko, Linux PM
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
After introducing acpi_dev_parent() in commit 62fcb99bdf10 ("ACPI: Drop
parent field from struct acpi_device"), it is better to use it instead
of accessing the dev.parent field in struct acpi_device directly.
Modify acpi_node_get_parent() accordingly.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/property.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Index: linux-pm/drivers/acpi/property.c
===================================================================
--- linux-pm.orig/drivers/acpi/property.c
+++ linux-pm/drivers/acpi/property.c
@@ -1269,10 +1269,11 @@ acpi_node_get_parent(const struct fwnode
return to_acpi_data_node(fwnode)->parent;
}
if (is_acpi_device_node(fwnode)) {
- struct device *dev = to_acpi_device_node(fwnode)->dev.parent;
+ struct acpi_device *parent;
- if (dev)
- return acpi_fwnode_handle(to_acpi_device(dev));
+ parent = acpi_dev_parent(to_acpi_device_node(fwnode));
+ if (parent)
+ return acpi_fwnode_handle(parent);
}
return NULL;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ACPI: property: Use acpi_dev_parent()
2022-08-29 16:12 [PATCH v1] ACPI: property: Use acpi_dev_parent() Rafael J. Wysocki
@ 2022-08-29 17:00 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2022-08-29 17:00 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux ACPI, LKML, Linux PM
On Mon, Aug 29, 2022 at 06:12:33PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> After introducing acpi_dev_parent() in commit 62fcb99bdf10 ("ACPI: Drop
> parent field from struct acpi_device"), it is better to use it instead
> of accessing the dev.parent field in struct acpi_device directly.
>
> Modify acpi_node_get_parent() accordingly.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/acpi/property.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> Index: linux-pm/drivers/acpi/property.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/property.c
> +++ linux-pm/drivers/acpi/property.c
> @@ -1269,10 +1269,11 @@ acpi_node_get_parent(const struct fwnode
> return to_acpi_data_node(fwnode)->parent;
> }
> if (is_acpi_device_node(fwnode)) {
> - struct device *dev = to_acpi_device_node(fwnode)->dev.parent;
> + struct acpi_device *parent;
>
> - if (dev)
> - return acpi_fwnode_handle(to_acpi_device(dev));
> + parent = acpi_dev_parent(to_acpi_device_node(fwnode));
> + if (parent)
> + return acpi_fwnode_handle(parent);
> }
>
> return NULL;
>
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-29 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-29 16:12 [PATCH v1] ACPI: property: Use acpi_dev_parent() Rafael J. Wysocki
2022-08-29 17:00 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox