From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file Date: Mon, 16 Apr 2018 16:24:50 +0200 Message-ID: <4780353.WGAykbfPTG@amdc3058> References: <1523873525-23718-1-git-send-email-b.zolnierkie@samsung.com> <1523873525-23718-13-git-send-email-b.zolnierkie@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Daniel Lezcano Cc: Eduardo Valentin , Zhang Rui , Krzysztof Kozlowski , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Monday, April 16, 2018 03:24:57 PM Daniel Lezcano wrote: > On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote: > > exynos_tmu.h is used only by exynos_tmu.c so there is no need > > for a separate include file. > > > > There should be no functional changes caused by this patch. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > --- > > drivers/thermal/samsung/exynos_tmu.c | 18 +++++++++++++++- > > drivers/thermal/samsung/exynos_tmu.h | 41 ------------------------------------ > > 2 files changed, 17 insertions(+), 42 deletions(-) > > delete mode 100644 drivers/thermal/samsung/exynos_tmu.h > > > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > > index 7975f33..197f267 100644 > > --- a/drivers/thermal/samsung/exynos_tmu.c > > +++ b/drivers/thermal/samsung/exynos_tmu.c > > @@ -34,8 +34,10 @@ > > #include > > #include > > #include > > +#include > > + > > This one should go away, no ? Yes, thanks for noticing (I've just sent v2 of this patch). . > Apart this. > > Acked-by: Daniel Lezcano Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics