Re: [rft] s2ram wakeup moves to .c, could fix few machines

Sam Ravnborg
2008-02-10T21:21:24Z

On Sun, Feb 10, 2008 at 10:14:57PM +0100, Pavel Machek wrote:
> On Fri 2008-02-08 16:32:08, H. Peter Anvin wrote:
> > Rafael J. Wysocki wrote:
> >>
> >> Consolidated patch is appended. I'll test it tomorrow on x86-64.
> >>
> >> I'd like to add the cleaned up beeping code to it and perhaps try to push it
> >> for -mm testing without any further changes. We can still do more cleanups in
> >> followup patches.
> >>
> >
> > The other thing to figure out is to what extent we can clean up the
> > conditionals in the video mode code by refactoring. All they really do
> > here is save space by removing functionality not needed for wakeup, because
> > I didn't know how much space was realistic.
> >
> > It's possible we can remove them altogether by having a dummy boot_params
> > structure (4K).
>
> I'd say that few #ifdefs are acceptable if we save 4K, but...
>
> Sam... is there something that urgently needs fixing?

I will prepare some build system bits later.
So please use what you have today and I can always clean it up
when I have something better.

So for the bits I have competence in - no issues.

Sam