Re: [rft] s2ram wakeup moves to .c, could fix few machines

Pavel Machek
2008-02-07T22:49:08Z

On Thu 2008-02-07 14:45:35, H. Peter Anvin wrote:
> Rafael J. Wysocki wrote:
>
>> ENTRY(wakeup_long64)
>> wakeup_long64:
>> - movq saved_magic, %rax
>> - movq $0x123456789abcdef0, %rdx
>> - cmpq %rdx, %rax
>> - jne bogus_64_magic
>> + movq saved_magic, %rax
>> + movq $0x123456789abcdef0, %rdx
>> + cmpq %rdx, %rax
>> + jne bogus_64_magic
>
> A random magic is probably more likely to be unique than something like
> that.

This is already "unlikely enough", I'd say. It does not look like a
pointer, and it is long enough.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html