From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D0CA301471 for ; Sun, 5 Jul 2026 10:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783246783; cv=none; b=AvJCWL+BGI/h0iNcUFqw+e9pFfV7UxanNT7KEXzm+Cth0oyXZJI5WYysnahAgXdNhaokoS69HpNuZZPSe8LaHvdLyxIWBT6PEg4npqHqbvIPqXKBwu7zO6x8ZrWg2tMQLx+bhZV09s7ccIXA3cUD+o/2N2NzzX3GzsrCS+FDBW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783246783; c=relaxed/simple; bh=xBY+X7nL5AZz+gzrhUliZqJVFe9VocGCCYH1oenG6VQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FBKyJsBkaunYtbwzNBWUjOz4h/YLxCVs8uiqQYb7nFSvlGstsq/VvQe68DR63/J8yN3gQ/pqjLpnoQSOJ/h2iq/EBjpjrXjyYQvJIzmYbQU9gTUsGBbnGOsGmCW0+Xx/MBJ/ToXYYjXPzIh/5GTw1xchy8BgmlsjksTrNDUWOCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d/p/r6Ck; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JrB6TEO+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d/p/r6Ck"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JrB6TEO+" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6651rSqG419357 for ; Sun, 5 Jul 2026 10:19:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Xpbe7dAQLjNnNWc71nhAnTIRBBKphawt2IUV/ANXlWw=; b=d/p/r6Ckktk9AztM pGL3GsxkNLlTiaAAekulPH8g6Z9lVwCHBHkqkfzqMlZc0jPDh2RUkq4r97Uh6Hry bkT7G9R/Sx/AceKnkVKzXGQVqDYSzmpn4tVKuhl3JzrCrSP0Ar03ljwrYrQCPZeV xIDsucmeigO5sbEFiX7dm4z/3Yk3lmgc5//ZxJYcRhQe7vn47rl8sz7y5DtgyaQF pfID5+WfqrlG+FhaaTmIEZxmJxBO4GSJFd9/PMaDg45fOJqJ5CbnUugtO5jzUKJm T/f1et17VY7/NQZ1AYciPCvMYDJkd+DmuX/t5CyENXMCnzlabqweu9AqHCV7FqAx +WbiZA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6td3ag8r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 10:19:41 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38101e6fc6cso3915039a91.0 for ; Sun, 05 Jul 2026 03:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783246781; x=1783851581; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xpbe7dAQLjNnNWc71nhAnTIRBBKphawt2IUV/ANXlWw=; b=JrB6TEO+Eg09ew9nbnj1qDaJaCkIR/ELjm06lr4v91afQKD/Jzfy1DxTuQ0tjof9hV AwQC5OyDzj+9MnKfjMVownl/AOf9KplDEJsKDRQB+QPO/3ZzgU/ws4EcnXlzVwXfeoBe 6QHFCJaGq2xMAMPE78bvmBJepJbsbwnTGAXxxJ86u+lrDKMBdafbJ2XhguMibxDrsYUo RmprW1ENYIANs0LvbPJJVFBus2URh9wWdz6mgbzZ9L/t80rbTbTIJqKMlwp17Hu5VFXm FxXicAv9PBVSSuz7ltbhJRNcT17f9PRIfokIqbHTcOpDeXcD/gqS3zU6itVp8ucqYTe2 H98Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783246781; x=1783851581; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xpbe7dAQLjNnNWc71nhAnTIRBBKphawt2IUV/ANXlWw=; b=Nywns2cVK7lSJ7/gS0sYhCQiQ9WgV6riNnS1E+exF7LOsqduW+ScYaS3uMbYySMM1l UFmDzC/SaqkqXIu45R+BzwiqzMWKW8Jna1B6lucaFZbM+Wk+MoUB57fBoPaVsE0w3OU3 lrYECUjBoNpstnQzy4n+OpADC6/MCp8FkknX0WAyP4GH9veh+cM9Tm0tOCeGqQpNe5qo G2SyPPvyFe2Ntc/2O7p8QssC+kPzogdzxGGMQxUe/ribOlL2EKIA3L3Bx9gWchgPSMlT ajzJhktQ44mos8rNySo5HVOpToCwrpwcY0SfxR1BjqPNpazP7pjXQ9ViChOEadUPFJUF yiqQ== X-Forwarded-Encrypted: i=1; AHgh+Rr9fypHkUc9Jc4YkOMXIIUC6Ng0UIfoWyavwU9a/INO99mUScrJ0uetzdgzwpPvUqZ7Ybq+HFZQjg==@vger.kernel.org X-Gm-Message-State: AOJu0Yz1kE10FQLm3EG5SAO7ntmtCAvgtElV3D9UBBqWv1s8Yny2txKA aWzUmfJDsXl702jiNPORyGdm0f+uC5f+4F13HNaqtQ1V/9W58KIbhgU7/X+K+ipglYCEwOjdUaG XTQ82/tCsWm+9AePQ0sMxoZFYhzOO2L6YIlmVd8diyeP0Ff5sn0Ipko66lVGTxA== X-Gm-Gg: AfdE7cnobMq5+QmaV5azgfAZAgYjukkUfLzMhW1QaoxzGxrCXRaTKYQDcB4ypqzZjE9 oAIMqGSeBODuyO8qUNYzwSnA1XxxyonwMEyXl83kn6RtgDCao1F9llgvGH0piwnUKEjT1/q6n5T +bH9zOM9IcCJQHnvqVHoT0qX3rpXV/sfwi/atX5P75rVhw99aqCRclO7kcsM6dwJnn4hXENyqGO YbfHsGi5fnpKu8oPvXFu1qDpZn4zV1RB5rTpDiX0gxcvCaobL8XXUueM/IaLMYWJ+fXyFWrIf89 a4Ql0AyvkIZXYQOFSZdHlb/jsD8y/TOeVLpRyyAxsmYjSLSOnOtMIVv8MM8zF7HWWYB1hTAtvGt Yh/c4ZFy4H6eyIBVvsekU1ODoE2ts6NHa79BRds2O9g== X-Received: by 2002:a17:90b:3fcf:b0:368:af5c:5925 with SMTP id 98e67ed59e1d1-3829f100a13mr5642968a91.23.1783246780491; Sun, 05 Jul 2026 03:19:40 -0700 (PDT) X-Received: by 2002:a17:90b:3fcf:b0:368:af5c:5925 with SMTP id 98e67ed59e1d1-3829f100a13mr5642945a91.23.1783246779990; Sun, 05 Jul 2026 03:19:39 -0700 (PDT) Received: from [192.168.1.13] ([106.222.231.34]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3113c88041fsm9099831eec.15.2026.07.05.03.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jul 2026 03:19:39 -0700 (PDT) Message-ID: <49566b40-324b-4234-bb07-09e84749e666@oss.qualcomm.com> Date: Sun, 5 Jul 2026 15:49:31 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/10] arm64: dts: qcom: kodiak: Enable CDSP & Modem cooling To: Dmitry Baryshkov Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260703-qmi-tmd-v4-0-3882189c1f83@oss.qualcomm.com> <20260703-qmi-tmd-v4-6-3882189c1f83@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDEwNiBTYWx0ZWRfX2dAkCG7XaQcs 6E1VUH8NGnnTAtmX35zhzSoB7et6MXG9jTc/P6ZgoAPTV75cIy++gQROLJUNV1LoxiNRPJIAohe MRHxWftT0AD2fYOMcms7qpgs95WEB+0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDEwNiBTYWx0ZWRfX2g1Ykt59r2db LOCbPT484bwBNaYzni7zN+0cwHUJAoFyMNhpozJubJRSnSUPiTNGeiY+sGwTQ6ShhFRIeF524Qs lW5Ag+Y7UIbKONJR6QnqdUCthvvdBIMmuOiq/HCFV4E/28nEv4wO5UNAqRu5X831ikfyZvSaqx1 gNSaw48PAFi6dP9cYmzwqC5DvNTVZVl92PCT/yMyL9Q25d9/xR+FsaN8XxEK1iMMssVposGGODt 7+u0AM/hGrDFDYOoE79/a/U00lNnByb4smfrEoFtIepjoHkvHMAt64a8NnptKbBbSGRldrHkZUx OmbCY9LW8OgYh+uP5zaSEUGjyhBH7yZ5sbPpIoshynSbX8HUXgeYKFZbgsU7tC1DbcEi5i4GZdH pOUYN7rTmaITBAmzPjcYV26vBFHl83Xtdid0XeS/6qU+qnbX7SkZVdPk+J1NM4Z0FI+ec1qsRfN 1/A/Xsu6V32TPeBV/hw== X-Proofpoint-GUID: DZVKwEjvTNV7q1JcyynvT_25irI5UrRv X-Proofpoint-ORIG-GUID: DZVKwEjvTNV7q1JcyynvT_25irI5UrRv X-Authority-Analysis: v=2.4 cv=b9GCJNGx c=1 sm=1 tr=0 ts=6a4a2fbd cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JaHktJlP2QtFIg7UHuVw+g==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=dzk2ctQkzv_BcHpUmM0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-04_03,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050106 On 7/3/2026 9:18 PM, Dmitry Baryshkov wrote: > On Fri, Jul 03, 2026 at 10:33:09AM +0530, Gaurav Kohli wrote: >> Unlike the CPU, the CDSP/Modem does not throttle its speed automatically >> when it reaches high temperatures in kodiak. >> >> Set up CDSP cooling by throttling the cdsp when it reaches 100°C and >> for modem when it reaches to 95°C. >> >> Since the remoteproc_mpss node doesn't exist on non modem boards, the >> cooling-maps that reference it cause DT compilation errors. To fix that >> remove inherited mdmss cooling-map nodes. >> >> Signed-off-by: Gaurav Kohli >> --- >> arch/arm64/boot/dts/qcom/kodiak.dtsi | 134 ++++++++++++++++++++- >> .../boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts | 17 +++ >> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 17 +++ >> .../dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts | 17 +++ >> .../boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts | 17 +++ >> .../boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi | 17 +++ >> .../boot/dts/qcom/sc7280-herobrine-wifi-sku.dtsi | 16 +++ >> 7 files changed, 231 insertions(+), 4 deletions(-) >> >> @@ -7716,6 +7722,8 @@ map0 { >> }; >> >> nspss0-thermal { >> + polling-delay-passive = <200>; > > Why? This applies to all added polling delays. Thanks for review, will update the reasoning(passive polling mode) in commit message. > >> + >> thermal-sensors = <&tsens1 3>; >> >> trips { >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts b/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts >> index bb5a42b038f1..400d128132fc 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts >> @@ -24,6 +24,23 @@ >> /delete-node/ &adsp_mem; >> /delete-node/ &cdsp_mem; >> /delete-node/ &ipa_fw_mem; >> + >> +&mdmss0_thermal { >> + /delete-node/ cooling-maps; > > Don't kill what is unnecessary to be killed. Remove only MPSS maps. Thanks for review, will change this to delete only the MPSS map entries. > >> +}; >> + >> +&mdmss1_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss2_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss3_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> /delete-node/ &mpss_mem; >> /delete-node/ &remoteproc_mpss; >> /delete-node/ &remoteproc_wpss; >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> index 37a3b51323ce..187bc2899191 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> @@ -25,6 +25,23 @@ >> /delete-node/ &rmtfs_mem; >> /delete-node/ &adsp_mem; >> /delete-node/ &cdsp_mem; >> + >> +&mdmss0_thermal { >> + /delete-node/ cooling-maps; > > But MPSS is there. Why are you removing it? thanks for review, Let me recheck this and fix this. > >> +}; >> + >> +&mdmss1_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss2_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss3_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> /delete-node/ &video_mem; >> /delete-node/ &wlan_ce_mem; >> /delete-node/ &wpss_mem; >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts >> index a5ad796cb65d..1e190ed18ae5 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts >> @@ -22,6 +22,23 @@ >> /delete-node/ &cdsp_mem; >> /delete-node/ &ipa_fw_mem; >> /delete-node/ &mpss_mem; >> + >> +&mdmss0_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss1_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss2_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss3_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> /delete-node/ &remoteproc_mpss; >> /delete-node/ &remoteproc_wpss; >> /delete-node/ &rmtfs_mem; >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts >> index f47efca42d48..8e8dd4efd8c0 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts >> @@ -23,6 +23,23 @@ >> /delete-node/ &adsp_mem; >> /delete-node/ &cdsp_mem; >> /delete-node/ &ipa_fw_mem; >> + >> +&mdmss0_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss1_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss2_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss3_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> /delete-node/ &mpss_mem; >> /delete-node/ &remoteproc_mpss; >> /delete-node/ &remoteproc_wpss; >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >> index b721a8546800..1e9d7e7b5fa2 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >> @@ -26,8 +26,25 @@ &ipa { >> status = "okay"; >> }; >> >> +&mdmss0_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss1_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss2_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss3_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> &remoteproc_mpss { >> compatible = "qcom,sc7280-mss-pil"; >> + /delete-property/ #cooling-cells; >> reg = <0 0x04080000 0 0x10000>, <0 0x04180000 0 0x48>; >> reg-names = "qdsp6", "rmb"; >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-wifi-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-wifi-sku.dtsi >> index 3ebc915f0dc2..6642076f62c4 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-wifi-sku.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-wifi-sku.dtsi >> @@ -7,6 +7,22 @@ >> >> /* WIFI SKUs save 256M by not having modem/mba/rmtfs memory regions defined. */ >> >> +&mdmss0_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss1_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss2_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> +&mdmss3_thermal { >> + /delete-node/ cooling-maps; >> +}; >> + >> /delete-node/ &mpss_mem; >> /delete-node/ &remoteproc_mpss; >> /delete-node/ &rmtfs_mem; >> >> -- >> 2.34.1 >> >