public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Wilczynski, Michal" <michal.wilczynski@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v1] ACPI: processor: Refine messages in acpi_early_processor_control_setup()
Date: Thu, 20 Jul 2023 10:38:56 +0200	[thread overview]
Message-ID: <496d7fd1-8d15-7566-f3e0-07a88e477fe2@intel.com> (raw)
In-Reply-To: <2703565.mvXUDI8C0e@kreacher>



On 7/19/2023 6:02 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The source and meaning of the messages printed by
> acpi_early_processor_control_setup() is unclear, so add a pr_fmt()
> definition to acpi_processor.c and expand the messages to make it
> clear that they are about CPUs.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>
> Based on linux-next.
>
> ---
>  drivers/acpi/acpi_processor.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/acpi_processor.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/acpi_processor.c
> +++ linux-pm/drivers/acpi/acpi_processor.c
> @@ -9,6 +9,7 @@
>   * Copyright (C) 2013, Intel Corporation
>   *                     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>   */
> +#define pr_fmt(fmt) "ACPI: " fmt
>  
>  #include <linux/acpi.h>
>  #include <linux/device.h>
> @@ -611,9 +612,9 @@ static bool __init acpi_early_processor_
>  void __init acpi_early_processor_control_setup(void)
>  {
>  	if (acpi_early_processor_osc()) {
> -		pr_info("_OSC evaluated successfully\n");
> +		pr_info("_OSC evaluated successfully for all CPUs\n");
>  	} else {
> -		pr_info("_OSC evaluation failed, trying _PDC\n");
> +		pr_info("_OSC evaluation for CPUs failed, trying _PDC\n");
>  		acpi_early_processor_set_pdc();
>  	}
>  }

Looks good to me,
Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com>
>
>
>


      reply	other threads:[~2023-07-20  8:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 16:02 [PATCH v1] ACPI: processor: Refine messages in acpi_early_processor_control_setup() Rafael J. Wysocki
2023-07-20  8:38 ` Wilczynski, Michal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496d7fd1-8d15-7566-f3e0-07a88e477fe2@intel.com \
    --to=michal.wilczynski@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox