Re: [PATCH v4 1/2] cpufreq: tegra124: Remove use of disable_cpufreq

Viresh Kumar
2025-05-19T10:17:28Z

On 09-05-25, 12:04, Jon Hunter wrote:
> > diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
> > index 514146d98bca2d8aa59980a14dff3487cd8045f6..bc0691e8971f9454def37f489e4a3e244100b9f4 100644
> > --- a/drivers/cpufreq/tegra124-cpufreq.c
> > +++ b/drivers/cpufreq/tegra124-cpufreq.c
> > @@ -168,7 +168,10 @@ static int __maybe_unused tegra124_cpufreq_resume(struct device *dev)
> > disable_dfll:
> > clk_disable_unprepare(priv->dfll_clk);
> > disable_cpufreq:
> > - disable_cpufreq();
> > + if (!IS_ERR(priv->cpufreq_dt_pdev)) {
> > + platform_device_unregister(priv->cpufreq_dt_pdev);
> > + priv->cpufreq_dt_pdev = ERR_PTR(-ENODEV);
> > + }
>
> So you are proposing to unregister the device in resume? That seems odd. I
> see there is no remove for this driver, but I really don't see the value in
> this.

This is the failure path and the driver is trying to disable itself
here. Instead of using the disable_cpufreq() (which isn't designed for
this usecase), I suggested removing the device itself as the driver
will be unusable after this anyway.

--
viresh