Re: [PATCH v4 2/2] cpufreq: tegra124: Allow building as a module

Jon Hunter
2025-05-14T10:31:12Z

On 13/05/2025 05:26, Aaron Kling wrote:

...

>>> +static void __exit tegra_cpufreq_module_exit(void)
>>> +{
>>> + if (platform_device && !IS_ERR(platform_device))
>>> + platform_device_unregister(platform_device);
>>
>> The device is unregistered in the remove. Why do we need this?
>
> These are separate things, aren't they? What's unregistered in the
> remove is the cpufreq-dt device. And what's unregistered here is the
> tegra124-cpufreq device. Not the same thing, unless I'm really missing
> something.

Thanks for the correction. OK, but I am still not sure about patch 1/2.

Jon

--
nvpublic