From: Tejun Heo <tj@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: cl@linux-foundation.org, jeff@garzik.org,
pm list <linux-pm@lists.linux-foundation.org>,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
Oren Laadan <orenl@librato.com>,
dhowells@redhat.com, jens.axboe@oracle.com,
akpm@linux-foundation.org, arjan@linux.intel.com, mingo@elte.hu
Subject: Re: [PATCH 01/19] freezer: don't get over-anxious while waiting
Date: Fri, 02 Oct 2009 19:56:33 +0900 [thread overview]
Message-ID: <4AC5DC61.9060900@kernel.org> (raw)
In-Reply-To: <200910012304.00720.rjw@sisk.pl>
Hello, Pavel, Rafael.
Rafael J. Wysocki wrote:
> On Thursday 01 October 2009, Pavel Machek wrote:
>>> Freezing isn't exactly the most latency sensitive operation and
>>> there's no reason to burn cpu cycles and power waiting for it to
>>> complete. msleep(10) instead of yield(). This should improve
>>> reliability of emergency hibernation.
>> i don't see how it improves reliability, but its probably ok.
It's about battery. When emergency hibernation kicks in and something
is taking a while to freeze (usually nfs does this for me) burning
power waiting for it to finish is a pretty bad idea.
>> Well... for hibernation anyway. I can imagine cgroup users where
>> freeze is so fast that this matters. rjw cc-ed. pavel
>
> Thanks. I'd like to hear from the cgroup freezer people about that.
Oh... didn't know that. 10ms sleeps really matter there?
--
tejun
next prev parent reply other threads:[~2009-10-02 10:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1254384558-1018-1-git-send-email-tj@kernel.org>
[not found] ` <1254384558-1018-2-git-send-email-tj@kernel.org>
[not found] ` <20091001183655.GA9995@atrey.karlin.mff.cuni.cz>
2009-10-01 21:04 ` [PATCH 01/19] freezer: don't get over-anxious while waiting Rafael J. Wysocki
[not found] ` <200910012304.00720.rjw@sisk.pl>
2009-10-02 10:56 ` Tejun Heo [this message]
2009-10-02 19:47 ` Oren Laadan
[not found] ` <4AC658C2.6070406@librato.com>
2009-10-02 21:04 ` Matt Helsley
[not found] ` <20091002210445.GE4189@count0.beaverton.ibm.com>
2009-10-02 21:21 ` Rafael J. Wysocki
[not found] ` <200910022321.11796.rjw@sisk.pl>
2009-10-03 0:43 ` Tejun Heo
[not found] ` <4AC69E3F.80301@kernel.org>
2009-10-03 19:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC5DC61.9060900@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=cl@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=orenl@librato.com \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox