Re: [PATCH 01/19] freezer: don't get over-anxious while waiting

Tejun Heo
2009-10-02T10:56:33Z

Hello, Pavel, Rafael.

Rafael J. Wysocki wrote:
> On Thursday 01 October 2009, Pavel Machek wrote:
>>> Freezing isn't exactly the most latency sensitive operation and
>>> there's no reason to burn cpu cycles and power waiting for it to
>>> complete. msleep(10) instead of yield(). This should improve
>>> reliability of emergency hibernation.
>> i don't see how it improves reliability, but its probably ok.

It's about battery. When emergency hibernation kicks in and something
is taking a while to freeze (usually nfs does this for me) burning
power waiting for it to finish is a pretty bad idea.

>> Well... for hibernation anyway. I can imagine cgroup users where
>> freeze is so fast that this matters. rjw cc-ed. pavel
>
> Thanks. I'd like to hear from the cgroup freezer people about that.

Oh... didn't know that. 10ms sleeps really matter there?

--
tejun