public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "linux-pm@lists.linux-foundation.org"
	<linux-pm@lists.linux-foundation.org>,
	"dri-devel@lists.sourceforge.net"
	<dri-devel@lists.sourceforge.net>
Subject: Re: Hibernation out-of-memory problem.
Date: Tue, 13 Oct 2009 21:25:13 +0200	[thread overview]
Message-ID: <4AD4D419.9000302@vmware.com> (raw)
In-Reply-To: <200910122317.59973.rjw@sisk.pl>

Rafael J. Wysocki wrote:
> On Saturday 10 October 2009, Thomas Hellstrom wrote:
>   
>> Hi!
>>
>> I'm trying to port a graphics DRM device driver over to the new power 
>> management hooks in
>>
>> struct dev_pm_ops.
>>
>> During the "prepare" call, Video RAM contents may be copied either to 
>> shmem objects or pages allocated using alloc_page().
>> Unfortunately, this seems to lead to the hibernation process running out 
>> of free pages.
>>
>> One possible cause is that the function swsusp_shrink_memory() is called 
>> before the prepare() call, and therefore doesn't free up enough memory.
>>
>> What would be the correct way around this? Should swsusp_shrink_memory() 
>> be moved to after prepare(), or is it possible to get some kind of 
>> notification after user space processes is stopped, but before 
>> swsusp_shrink_memory()?
>>     
>
> There are suspend/hibernation notifiers that can be used for this purpose.
>
> Thanks,
> Rafael
>   
Thanks, Rafael. I tried that and it works fine.

Now, it may be that others will hit this problem as well, as the 
documentation in <linux/pm.h> states that it is safe to make
GFP_KERNEL allocations from within a prepare() callback. Such 
allocations executed in the prepare() preceeding a freeze() will 
probably make the amount of previously freed memory insufficient.

Thanks,

Thomas

  reply	other threads:[~2009-10-13 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4AD0F4D0.2090809@vmware.com>
2009-10-12 21:17 ` Hibernation out-of-memory problem Rafael J. Wysocki
2009-10-13 19:25   ` Thomas Hellstrom [this message]
2009-10-13 20:35     ` Rafael J. Wysocki
2009-10-10 20:55 Thomas Hellstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD4D419.9000302@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox