public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.com>,
	Andi Kleen <ak@linux.intel.com>, Jiri Kosina <jkosina@suse.cz>,
	Ingo Molnar <mingo@elte.hu>, Oleg Nesterov <oleg@redhat.com>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-pm@lists.linux-foundation.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 7/9] PM: Add suspend blocking work.
Date: Sat, 24 Apr 2010 09:43:25 +0200	[thread overview]
Message-ID: <4BD2A11D.7040507@kernel.org> (raw)
In-Reply-To: <r2zd6200be21004240021sfaec0f3ft8a1ea7c1b12ea52a@mail.gmail.com>

Hello,

On 04/24/2010 09:21 AM, Arve Hjønnevåg wrote:
> OK, I'll try to do this. Do you want it in a separate header file as well?

I think it would fit better with the rest of suspend_blocker.h APIs
but it's not like I thought about it hard and long, so please take my
preference with a grain of salt.

> I only touch the work structure after the callback has returned for
> suspend blocking work, which does not allow that.

Oh, you're right.  I missed the current_work_blocks_suspend test.
Sorry about that.

Thanks.

-- 
tejun

  parent reply	other threads:[~2010-04-24  7:43 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1271984938-13920-1-git-send-email-arve@android.com>
2010-04-23  1:08 ` [PATCH 1/9] PM: Add suspend block api Arve Hjønnevåg
     [not found] ` <1271984938-13920-2-git-send-email-arve@android.com>
2010-04-23  1:08   ` [PATCH 2/9] PM: suspend_block: Add driver to access suspend blockers from user-space Arve Hjønnevåg
2010-04-23  1:08     ` [PATCH 3/9] PM: suspend_block: Abort task freezing if a suspend_blocker is active Arve Hjønnevåg
     [not found]     ` <1271984938-13920-4-git-send-email-arve@android.com>
2010-04-23  1:08       ` [PATCH 4/9] PM: suspend_block: Switch to list of active and inactive suspend blockers Arve Hjønnevåg
     [not found]       ` <1271984938-13920-5-git-send-email-arve@android.com>
2010-04-23  1:08         ` [PATCH 5/9] PM: suspend_block: Add debugfs file Arve Hjønnevåg
2010-04-23  1:08           ` [PATCH 6/9] PM: suspend_block: Add suspend_blocker stats Arve Hjønnevåg
2010-04-23  1:08             ` [PATCH 7/9] PM: Add suspend blocking work Arve Hjønnevåg
     [not found]             ` <1271984938-13920-8-git-send-email-arve@android.com>
2010-04-23  1:08               ` [PATCH 8/9] Input: Block suspend while event queue is not empty Arve Hjønnevåg
     [not found]               ` <1271984938-13920-9-git-send-email-arve@android.com>
2010-04-23  1:08                 ` [PATCH 9/9] power_supply: Block suspend while power supply change notifications are pending Arve Hjønnevåg
2010-04-23 20:56                 ` [PATCH 8/9] Input: Block suspend while event queue is not empty Randy Dunlap
     [not found]                 ` <20100423135625.1e12d005.randy.dunlap@oracle.com>
2010-04-23 21:08                   ` Dmitry Torokhov
2010-04-24  4:58                   ` Arve Hjønnevåg
     [not found]                   ` <201004231408.15885.dmitry.torokhov@gmail.com>
2010-04-24  5:02                     ` Arve Hjønnevåg
2010-04-23  8:16               ` [PATCH 7/9] PM: Add suspend blocking work Tejun Heo
     [not found]               ` <4BD1576E.5070401@kernel.org>
2010-04-23 12:20                 ` Oleg Nesterov
     [not found]                 ` <20100423122032.GA23544@redhat.com>
2010-04-23 22:49                   ` Arve Hjønnevåg
     [not found]                   ` <y2ud6200be21004231549q8e52c9c0z441d82b5a15e177d@mail.gmail.com>
2010-04-24  5:21                     ` Arve Hjønnevåg
2010-04-24  6:33                     ` Tejun Heo
     [not found]                     ` <4BD290CC.4080601@kernel.org>
2010-04-24  7:21                       ` Arve Hjønnevåg
     [not found]                       ` <r2zd6200be21004240021sfaec0f3ft8a1ea7c1b12ea52a@mail.gmail.com>
2010-04-24  7:43                         ` Tejun Heo [this message]
2010-04-26 14:06                     ` Oleg Nesterov
2010-04-23 20:58           ` [PATCH 5/9] PM: suspend_block: Add debugfs file Randy Dunlap
     [not found]           ` <20100423135853.478af057.randy.dunlap@oracle.com>
2010-04-24  3:23             ` Arve Hjønnevåg
     [not found]             ` <n2rd6200be21004232023hf138c65dia5b378825124933d@mail.gmail.com>
2010-04-24  4:24               ` Randy Dunlap
2010-04-24  4:54                 ` Arve Hjønnevåg
2010-04-25 18:15             ` Greg KH
     [not found]             ` <20100425181517.GA22676@kroah.com>
2010-04-25 19:53               ` Randy Dunlap
     [not found]               ` <4BD49D9D.7020004@oracle.com>
2010-04-26  0:00                 ` tytso
     [not found]                 ` <20100426000025.GE667@thunk.org>
2010-04-26  0:23                   ` Randy Dunlap
     [not found]                   ` <4BD4DCEA.8060602@oracle.com>
2010-04-26  0:45                     ` tytso
     [not found]                     ` <20100426004558.GA13043@thunk.org>
2010-04-26  0:50                       ` Randy Dunlap
2010-04-26  1:39                     ` Alan Stern
2010-04-26  6:24                 ` Brian Swetland
     [not found]                 ` <p2xa55d774e1004252324i4dca8cc3y1ffacec838c436f8@mail.gmail.com>
2010-04-26 13:28                   ` Randy Dunlap
2010-04-23  2:25     ` [PATCH 2/9] PM: suspend_block: Add driver to access suspend blockers from user-space Matt Helsley
     [not found]     ` <20100423022522.GB32490@count0.beaverton.ibm.com>
2010-04-23  3:54       ` Arve Hjønnevåg
2010-04-23  4:38       ` Greg KH
2010-04-23  8:43     ` Pavel Machek
     [not found]     ` <20100423084349.GC1573@ucw.cz>
2010-04-23 16:43       ` Alan Stern
2010-04-24  1:53       ` tytso
     [not found]       ` <Pine.LNX.4.44L0.1004231242460.1777-100000@iolanthe.rowland.org>
2010-04-24  3:20         ` Arve Hjønnevåg
     [not found]         ` <i2zd6200be21004232020t46f4de0ct93b94e2bd67a6e76@mail.gmail.com>
2010-04-24  5:55           ` Pavel Machek
     [not found]       ` <20100424015334.GO14986@thunk.org>
2010-04-24  5:39         ` Pavel Machek
2010-04-23 16:33   ` [PATCH 1/9] PM: Add suspend block api Alan Stern
     [not found]   ` <Pine.LNX.4.44L0.1004231204450.1777-100000@iolanthe.rowland.org>
2010-04-23 16:45     ` Alan Stern
2010-04-24  2:15     ` Arve Hjønnevåg
2010-04-23  4:39 ` [PATCH 0/9] Suspend block api (version 4) Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD2A11D.7040507@kernel.org \
    --to=tj@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arve@android.com \
    --cc=dmitri.vorobiev@movial.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox