From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 7/9] PM: Add suspend blocking work. Date: Sat, 24 Apr 2010 09:43:25 +0200 Message-ID: <4BD2A11D.7040507@kernel.org> References: <1271984938-13920-1-git-send-email-arve@android.com> <1271984938-13920-4-git-send-email-arve@android.com> <1271984938-13920-5-git-send-email-arve@android.com> <1271984938-13920-6-git-send-email-arve@android.com> <1271984938-13920-7-git-send-email-arve@android.com> <1271984938-13920-8-git-send-email-arve@android.com> <4BD1576E.5070401@kernel.org> <20100423122032.GA23544@redhat.com> <4BD290CC.4080601@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= Cc: Dmitri Vorobiev , Andi Kleen , Jiri Kosina , Ingo Molnar , Oleg Nesterov , linux-kernel@vger.kernel.org, Thomas Gleixner , linux-pm@lists.linux-foundation.org, Andrew Morton List-Id: linux-pm@vger.kernel.org Hello, On 04/24/2010 09:21 AM, Arve Hj=F8nnev=E5g wrote: > OK, I'll try to do this. Do you want it in a separate header file as well? I think it would fit better with the rest of suspend_blocker.h APIs but it's not like I thought about it hard and long, so please take my preference with a grain of salt. > I only touch the work structure after the callback has returned for > suspend blocking work, which does not allow that. Oh, you're right. I missed the current_work_blocks_suspend test. Sorry about that. Thanks. -- = tejun