From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2/2] workqueues: export keventd_wq Date: Fri, 30 Apr 2010 07:52:12 +0200 Message-ID: <4BDA700C.3050509@kernel.org> References: <1272429119-12103-1-git-send-email-arve@android.com> <20100428194028.GA16389@redhat.com> <4BD89922.1040306@kernel.org> <201004282308.10751.rjw@sisk.pl> <20100429185851.GA13862@redhat.com> <20100429194447.GA17280@redhat.com> <20100429194545.GC17280@redhat.com> <4BDA67C1.7050709@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= Cc: Len Brown , Oleg Nesterov , linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On 04/30/2010 07:39 AM, Arve Hj=F8nnev=E5g wrote: > On Thu, Apr 29, 2010 at 10:16 PM, Tejun Heo wrote: >> Hello, >> >> On 04/29/2010 09:45 PM, Oleg Nesterov wrote: >>> -static struct workqueue_struct *keventd_wq __read_mostly; >>> +struct workqueue_struct *keventd_wq __read_mostly; >>> +EXPORT_SYMBOL(keventd_wq); >> >> Umm... does it have to be EXPORTed? Suspend block API can't be built >> as a module, right? > = > The suspend block api cannot be built as a module, but if > schedule_suspend_blocking_work will just call > queue_suspend_blocking_work(keventd_wq, work) it may as well be an > inline function which would require the export. I think it would be better to keep the thing inside the kernel, at least for now. It's not like we need to save cpu cycles spent on a function call here (in block suspend API and in workqueue general). Thanks. -- = tejun