From: Arjan van de Ven <arjan@linux.intel.com>
To: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Cc: khilman@ti.com, venki@google.com, ak@linux.intel.com,
len.brown@intel.com, peterz@infradead.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pm@lists.linux-foundation.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 2/4] cpuidle: Remove CPUIDLE_FLAG_IGNORE and dev->prepare()
Date: Fri, 28 Oct 2011 07:24:07 -0700 [thread overview]
Message-ID: <4EAABB07.3000305@linux.intel.com> (raw)
In-Reply-To: <20111028105020.7520.68014.stgit@localhost6.localdomain6>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/28/2011 3:50 AM, Deepthi Dharwar wrote:
> The cpuidle_device->prepare() mechanism causes updates to the
> cpuidle_state[].flags, setting and clearing CPUIDLE_FLAG_IGNORE
> to tell the governor not to chose a state on a per-cpu basis at
> run-time. State demotion is now handled by the driver and it returns
> the actual state entered. Hence, this mechanism is not required.
> Also this removes per-cpu flags from cpuidle_state enabling
> it to be made global.
>
having worked on some newer platforms....
this one is really still needed. doing this inside the actual states
does not work,
because if the deepest 3 states are invalid, the same (somewhat
expensive) test would have to be done 3 times,
and each of the states would have to fail before the 4th one gets chosen.
that's just not going to work
(in the state handler you can't know what other state to fall back to,
and especially not how to enter such a fallback state)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
iQEcBAEBAgAGBQJOqrsGAAoJEEHdSxh4DVnEu7EH/i5lEJctBAIubJOcZz/tvBFp
XYmAe/HqNtSXeHOVsJkTf8y4ppE8487exF7xxMik4GRN0CZNCtkyMezqDVu+eDim
O/UUbScsAc5cSY6mkjOFXLFup+mi1nkRUnAbxXEyTMhWwcbfr2OvcuO7l7TmATML
hu87P3PVEafEop3q2+uWMc57fFxnNFfEDqRx6N9V+OJKV5dHrRYL4G4E01fYGFLo
xTR0IW7nB15L0C29zk9uk/Dqow8SoJZA83c7p7AieP5zdntb6p7noIf03qmdp19f
fulwMwembCHivo+pLO+jAMhKD1T6VYoCyiYW0LHrQ2E07fayBhFJCxlazgKFcl0=
=FL6o
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-10-28 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111028104945.7520.83828.stgit@localhost6.localdomain6>
2011-10-28 10:50 ` [PATCH v9 1/4] cpuidle: Move dev->last_residency update to driver enter routine; remove dev->last_state Deepthi Dharwar
2011-10-28 10:50 ` [PATCH v9 2/4] cpuidle: Remove CPUIDLE_FLAG_IGNORE and dev->prepare() Deepthi Dharwar
2011-10-28 14:24 ` Arjan van de Ven [this message]
2011-10-31 7:32 ` Deepthi Dharwar
2011-10-28 10:50 ` [PATCH v9 3/4] cpuidle: Split cpuidle_state structure and move per-cpu statistics fields Deepthi Dharwar
2011-10-28 10:50 ` [PATCH v9 4/4] cpuidle: Single/Global registration of idle states Deepthi Dharwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAABB07.3000305@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=deepthi@linux.vnet.ibm.com \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).