* [RFC]: [PATCH] Export cpuidle_(un)register_governor
@ 2012-01-04 17:48 Jan-Simon Möller
2012-01-04 17:51 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Jan-Simon Möller @ 2012-01-04 17:48 UTC (permalink / raw)
To: linux-pm; +Cc: Arjan van de Ven
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Hi all!
This patch exports cpuidle_register_governor and cpuidle_unregister_governor
with EXPORT_SYMBOL_GPL (as the other cpuidle_(un)register_* ).
Reasoning: allow runtime loading of a cpuidle governor (mainly for
development for now).
Usually we don't need this as we're using built-ins for the governors - but
during development it is really handy to load and unload a cpuidle governor
(together with the cpuidle_sysfs_switch).
Comments ?
Best,
Jan-Simon
[-- Attachment #2: 0001-Export-cpuidle_register_governor-and-cpuidle_unregis.patch --]
[-- Type: text/x-patch, Size: 1166 bytes --]
>From a21a054fa64f898576ee62fced30508e0affe243 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan-Simon=20M=C3=B6ller?= <jansimon.moeller@gmx.de>
Date: Mon, 12 Dec 2011 14:40:56 +0100
Subject: [PATCH] Export cpuidle_register_governor and
cpuidle_unregister_governor with EXPORT_SYMBOL_GPL (as the
other cpuidle_(un)register_* ).
Reasoning: allow runtime loading of a cpuidle governor (mainly for
development for now).
---
drivers/cpuidle/governor.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
index ea2f8e7..552f5a4 100644
--- a/drivers/cpuidle/governor.c
+++ b/drivers/cpuidle/governor.c
@@ -97,6 +97,8 @@ int cpuidle_register_governor(struct cpuidle_governor *gov)
return ret;
}
+EXPORT_SYMBOL_GPL(cpuidle_register_governor);
+
/**
* cpuidle_replace_governor - find a replacement governor
* @exclude_rating: the rating that will be skipped while looking for
@@ -139,3 +141,4 @@ void cpuidle_unregister_governor(struct cpuidle_governor *gov)
mutex_unlock(&cpuidle_lock);
}
+EXPORT_SYMBOL_GPL(cpuidle_unregister_governor);
--
1.7.7
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC]: [PATCH] Export cpuidle_(un)register_governor
2012-01-04 17:48 [RFC]: [PATCH] Export cpuidle_(un)register_governor Jan-Simon Möller
@ 2012-01-04 17:51 ` Arjan van de Ven
0 siblings, 0 replies; 3+ messages in thread
From: Arjan van de Ven @ 2012-01-04 17:51 UTC (permalink / raw)
To: Jan-Simon Möller; +Cc: linux-pm
On 1/4/2012 9:48 AM, Jan-Simon Möller wrote:
> Hi all!
>
> This patch exports cpuidle_register_governor and cpuidle_unregister_governor
> with EXPORT_SYMBOL_GPL (as the other cpuidle_(un)register_* ).
>
> Reasoning: allow runtime loading of a cpuidle governor (mainly for
> development for now).
>
> Usually we don't need this as we're using built-ins for the governors - but
> during development it is really handy to load and unload a cpuidle governor
> (together with the cpuidle_sysfs_switch).
while I don't mind this for development purposes, I really am
opposed to loadable governors; cpufreq did this and it has been a huge
disaster in terms of complexity and locking.... it's really not a good
idea to repeat this mistake.... and it's not like normally this sort of
thing should or would switch.
_______________________________________________
linux-pm mailing list
linux-pm@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-pm
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC]: [PATCH] Export cpuidle_(un)register_governor
@ 2011-12-20 16:15 Jan-Simon Möller
0 siblings, 0 replies; 3+ messages in thread
From: Jan-Simon Möller @ 2011-12-20 16:15 UTC (permalink / raw)
To: linux-pm
[-- Attachment #1.1: Type: text/plain, Size: 551 bytes --]
Hi all!
This patch exports cpuidle_register_governor and cpuidle_unregister_governor
with EXPORT_SYMBOL_GPL (as the other cpuidle_(un)register_* ).
Reasoning: allow runtime loading of a cpuidle governor (mainly for
development for now).
Usually we don't need this as we're using built-ins for the governors - but
during developments it is really handy to load and unload a cpuidle governor
(together with the cpuidle_sysfs_switch).
Comments ?
Best,
Jan-Simon
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
[-- Attachment #1.2: Type: text/html, Size: 655 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Export-cpuidle_register_governor-and-cpuidle_unregis.patch --]
[-- Type: text/x-patch; name="0001-Export-cpuidle_register_governor-and-cpuidle_unregis.patch", Size: 1165 bytes --]
From a21a054fa64f898576ee62fced30508e0affe243 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan-Simon=20M=C3=B6ller?= <jansimon.moeller@gmx.de>
Date: Mon, 12 Dec 2011 14:40:56 +0100
Subject: [PATCH] Export cpuidle_register_governor and
cpuidle_unregister_governor with EXPORT_SYMBOL_GPL (as the
other cpuidle_(un)register_* ).
Reasoning: allow runtime loading of a cpuidle governor (mainly for
development for now).
---
drivers/cpuidle/governor.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
index ea2f8e7..552f5a4 100644
--- a/drivers/cpuidle/governor.c
+++ b/drivers/cpuidle/governor.c
@@ -97,6 +97,8 @@ int cpuidle_register_governor(struct cpuidle_governor *gov)
return ret;
}
+EXPORT_SYMBOL_GPL(cpuidle_register_governor);
+
/**
* cpuidle_replace_governor - find a replacement governor
* @exclude_rating: the rating that will be skipped while looking for
@@ -139,3 +141,4 @@ void cpuidle_unregister_governor(struct cpuidle_governor *gov)
mutex_unlock(&cpuidle_lock);
}
+EXPORT_SYMBOL_GPL(cpuidle_unregister_governor);
--
1.7.7
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-04 17:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04 17:48 [RFC]: [PATCH] Export cpuidle_(un)register_governor Jan-Simon Möller
2012-01-04 17:51 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2011-12-20 16:15 Jan-Simon Möller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).