From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH V4]mmc: remove MMC bus legacy suspend/resume method Date: Wed, 11 Apr 2012 15:41:57 +0200 Message-ID: <4F858A25.20302@stericsson.com> References: <20120411115438.GA303@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120411115438.GA303@intel.com> Sender: linux-mmc-owner@vger.kernel.org To: Chuanxiao Dong Cc: "linux-mmc@vger.kernel.org" , "linux-pm@lists.linux-foundation.org" , "cjb@laptop.org" List-Id: linux-pm@vger.kernel.org On 04/11/2012 01:54 PM, Chuanxiao Dong wrote: > MMC bus is using legacy suspend/resume method, which is not compatible if > runtime pm callbacks are used. In this scenario, MMC bus suspend/resume > callbacks cannot be called when system entering S3. So change to use the new > defined dev_pm_ops for system sleeping mode > > Signed-off-by: Chuanxiao Dong > --- > Changes in v2: > use SET_SYSTEM_SLEEP_PM_OPS to define sleep callbacks as Rafael > suggested > > Changes in v3: > remove NULL pointer define for runtime callbacks when PM_RUNTIME is not > selected, as Ulf Hansson suggested > > Changes in v4: > fix the warning when disable CONFIG_PM_RUNTIME > Looks good to me! Acked-by: Ulf Hansson Kind regards Ulf Hansson