From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linaro-dev@lists.linaro.org, linux-pm@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH v2] acpi: intel_idle : break dependency between modules
Date: Thu, 28 Jun 2012 17:26:48 +0530 [thread overview]
Message-ID: <4FEC4680.1090006@linux.vnet.ibm.com> (raw)
In-Reply-To: <4FEC3FAB.20706@linaro.org>
On 06/28/2012 04:57 PM, Daniel Lezcano wrote:
> On 06/28/2012 01:24 PM, Srivatsa S. Bhat wrote:
>> On 06/28/2012 02:16 PM, Daniel Lezcano wrote:
>>> When the system is booted with some cpus offline, the idle
>>> driver is not initialized. When a cpu is set online, the
>>> acpi code call the intel idle init function. Unfortunately
>>> this code introduce a dependency between intel_idle and acpi.
>>>
>>> This patch is intended to remove this dependency by using the
>>> notifier of intel_idle. This patch has the benefit of
>>> encapsulating the intel_idle driver and remove some exported
>>> functions.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>
>>
>> Looks good to me.
>
> Thanks for the review Srivatsa.
>
> Shall I consider it as an acked-by ?
>
Sure, go ahead! :-)
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2012-06-28 11:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 15:28 acpi_idle and max_cpus Daniel Lezcano
2012-06-17 20:18 ` Daniel Lezcano
2012-06-18 12:25 ` Deepthi Dharwar
2012-06-18 12:54 ` [linux-pm] " Daniel Lezcano
2012-06-19 6:54 ` Deepthi Dharwar
2012-06-19 7:03 ` Srivatsa S. Bhat
2012-06-19 7:18 ` Daniel Lezcano
2012-06-19 15:30 ` Thomas Renninger
2012-06-25 11:25 ` [PATCH] acpi, cpuidle: Register with cpuidle even if cpu is onlined after boot (beyond maxcpus) Srivatsa S. Bhat
2012-06-25 13:53 ` Thomas Renninger
2012-06-25 16:03 ` Srivatsa S. Bhat
2012-06-26 9:29 ` Thomas Renninger
2012-06-26 9:41 ` Daniel Lezcano
2012-06-26 9:58 ` Srivatsa S. Bhat
2012-06-26 10:42 ` Daniel Lezcano
2012-06-26 11:01 ` Thomas Renninger
2012-06-27 9:07 ` [PATCH] acpi: intel_idle : break dependency between modules Daniel Lezcano
2012-06-27 13:06 ` Thomas Renninger
[not found] ` <201206271506.29034.trenn-l3A5Bk7waGM@public.gmane.org>
2012-06-28 8:03 ` Daniel Lezcano
2012-06-28 8:46 ` [PATCH v2] " Daniel Lezcano
2012-06-28 11:24 ` Srivatsa S. Bhat
2012-06-28 11:27 ` Daniel Lezcano
2012-06-28 11:56 ` Srivatsa S. Bhat [this message]
2012-06-28 19:24 ` Rafael J. Wysocki
2012-06-29 8:39 ` Daniel Lezcano
2012-06-29 22:27 ` Rafael J. Wysocki
2012-07-01 19:36 ` Daniel Lezcano
2012-06-27 16:16 ` [PATCH] " Srivatsa S. Bhat
2012-06-28 7:34 ` [linux-pm] " Thomas Renninger
2012-06-28 11:23 ` Srivatsa S. Bhat
2012-06-26 11:07 ` [PATCH] acpi, cpuidle: Register with cpuidle even if cpu is onlined after boot (beyond maxcpus) Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEC4680.1090006@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-pm@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).