From: Shuah Khan <shuah@kernel.org>
To: Thomas Renninger <trenn@suse.de>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rafael@kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] tools/power/cpupower: fix compilation with STATIC=true
Date: Tue, 16 Oct 2018 08:28:47 -0600 [thread overview]
Message-ID: <4a4cb4dc-16d7-7f71-eb99-d4b1e7788862@kernel.org> (raw)
In-Reply-To: <2028892.8FmI4CMcI5@house>
On 10/16/2018 05:39 AM, Thomas Renninger wrote:
> On Tuesday, October 16, 2018 10:56:26 AM CEST Konstantin Khlebnikov wrote:
>> Rename duplicate sysfs_read_file into cpupower_read_sysfs and fix linking.
>>
>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
>
> Acked-by: Thomas Renninger <trenn@suse.de>
>
> Thanks!
>
>> - $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/sysfs.o
>> + $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/cpupower.o
>
> I also looked at this and would only have fixed half of it (overseeing above
> old leftover from cpupower lib introduction).
> I guess, this patch from Konstantin is better and the correct solution.
>
Thank you both. I will get this into 4.20-rc1 or rc2 depending on how timing
works.
I think this applies to stable as well.
thanks,
-- Shuah
prev parent reply other threads:[~2018-10-16 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 8:56 [PATCH] tools/power/cpupower: fix compilation with STATIC=true Konstantin Khlebnikov
2018-10-16 11:39 ` Thomas Renninger
2018-10-16 14:28 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a4cb4dc-16d7-7f71-eb99-d4b1e7788862@kernel.org \
--to=shuah@kernel.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).